status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Refactoring resolvePlugin out 

Reviewed By: BYK

Differential Revision: D7257553

fbshipit-source-id: 1abffa3606f1d342a571d7b22ee34272a995bf9f
This commit is contained in:
Peter van der Zee 2018-03-15 06:46:10 -07:00 committed by Facebook Github Bot
parent df9e523900
commit 9185eeb04b
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/metro/package.json
View File

@ -49,6 +49,7 @@
"babel-core": "^6.24.1", "babel-core": "^6.24.1",
"babel-generator": "^6.26.0", "babel-generator": "^6.26.0",
"babel-plugin-external-helpers": "^6.22.0", "babel-plugin-external-helpers": "^6.22.0",
"babel-plugin-react-transform": "^3.0.0",
"babel-plugin-transform-flow-strip-types": "^6.21.0", "babel-plugin-transform-flow-strip-types": "^6.21.0",
"babel-preset-es2015-node": "^6.1.1", "babel-preset-es2015-node": "^6.1.1",
"babel-preset-fbjs": "^2.1.4", "babel-preset-fbjs": "^2.1.4",

12
packages/metro/src/babel-bridge.js
View File

@ -32,7 +32,7 @@ const resolvePlugins6 = require('babel-preset-react-native/lib/resolvePlugins');
const getBabelRegisterConfig6 = () => require('./babelRegisterOnly').config; const getBabelRegisterConfig6 = () => require('./babelRegisterOnly').config;
// load given preset as a babel6 preset // load given preset as a babel6 preset
const getPreset6 = (preset: string) => const getPreset6 = (preset: string) =>
// $FlowFixMe: dynamic require can't be avoided // $FlowFixMe TODO t26372934 plugin require
require('babel-preset-' + preset); require('babel-preset-' + preset);
// ## Babel 7 stuff // ## Babel 7 stuff
@ -63,7 +63,7 @@ function resolvePlugins7(plugins: Array<any>) {
plugin = Array.isArray(plugin) ? plugin : [plugin]; plugin = Array.isArray(plugin) ? plugin : [plugin];
// Only resolve the plugin if it's a string reference. // Only resolve the plugin if it's a string reference.
if (typeof plugin[0] === 'string') { if (typeof plugin[0] === 'string') {
// $FlowFixMe these plugins need to be included here // $FlowFixMe TODO t26372934 plugin require
const required: ModuleES6 | {} = require('@babel/plugin-' + plugin[0]); const required: ModuleES6 | {} = require('@babel/plugin-' + plugin[0]);
// es6 import default? // es6 import default?
// $FlowFixMe should properly type this plugin structure // $FlowFixMe should properly type this plugin structure
@ -130,9 +130,9 @@ function makeMakeHMRConfig7() {
} }
return { return {
plugins: resolvePlugins7([ plugins: [
[ [
'react-transform', require('babel-plugin-react-transform').default,
{ {
transforms: [ transforms: [
{ {
@ -143,7 +143,7 @@ function makeMakeHMRConfig7() {
], ],
}, },
], ],
]), ],
}; };
}; };
} }
@ -383,7 +383,7 @@ function getBabelRegisterConfig7() {
return { return {
presets: [], presets: [],
plugins: PLUGINS.map(pluginName => plugins: PLUGINS.map(pluginName =>
// $FlowFixMe must require with dynamic string // $FlowFixMe TODO t26372934 plugin require
require(`@babel/plugin-${pluginName}`), require(`@babel/plugin-${pluginName}`),
), ),
only: _only, only: _only,