diff --git a/react-packager/src/Server/__tests__/Server-test.js b/react-packager/src/Server/__tests__/Server-test.js index 44f0cddf..660bac88 100644 --- a/react-packager/src/Server/__tests__/Server-test.js +++ b/react-packager/src/Server/__tests__/Server-test.js @@ -354,7 +354,6 @@ describe('processRequest', () => { server.processRequest(req, res); jest.runAllTimers(); - expect(res.setHeader).toBeCalledWith('Cache-Control', 'max-age=31536000'); expect(res.end).toBeCalledWith('i am image'); }); @@ -367,7 +366,6 @@ describe('processRequest', () => { server.processRequest(req, res); jest.runAllTimers(); expect(AssetServer.prototype.get).toBeCalledWith('imgs/a.png', 'ios'); - expect(res.setHeader).toBeCalledWith('Cache-Control', 'max-age=31536000'); expect(res.end).toBeCalledWith('i am image'); }); @@ -381,7 +379,6 @@ describe('processRequest', () => { server.processRequest(req, res); jest.runAllTimers(); expect(AssetServer.prototype.get).toBeCalledWith('imgs/a.png', 'ios'); - expect(res.setHeader).toBeCalledWith('Cache-Control', 'max-age=31536000'); expect(res.end).toBeCalledWith(mockData.slice(0, 4)); }); @@ -397,7 +394,6 @@ describe('processRequest', () => { 'imgs/\u{4E3B}\u{9875}/logo.png', undefined ); - expect(res.setHeader).toBeCalledWith('Cache-Control', 'max-age=31536000'); expect(res.end).toBeCalledWith('i am image'); }); }); diff --git a/react-packager/src/Server/index.js b/react-packager/src/Server/index.js index a704ae8b..39d4a750 100644 --- a/react-packager/src/Server/index.js +++ b/react-packager/src/Server/index.js @@ -473,7 +473,9 @@ class Server { data => { // Tell clients to cache this for 1 year. // This is safe as the asset url contains a hash of the asset. - res.setHeader('Cache-Control', 'max-age=31536000'); + if (process.env.REACT_NATIVE_ENABLE_ASSET_CACHING === true) { + res.setHeader('Cache-Control', 'max-age=31536000'); + } res.end(this._rangeRequestMiddleware(req, res, data, assetPath)); process.nextTick(() => { print(log(createActionEndEntry(processingAssetRequestLogEntry)), ['asset']);