Disable automocking from tests

Summary: We are flipping the switch all over Facebook, now that this part of the code is isolated we can do it in Metro as well.

Reviewed By: davidaurelio

Differential Revision: D5199449

fbshipit-source-id: 20c1bacc6dd2d314bd76bc5cc0ecd13266bf81c6

package.json

@@ -46,19 +46,10 @@
     "watch": "yarn run build --silent && node ./scripts/watch.js"
   },
   "jest": {
-    "automock": true,
     "testEnvironment": "node",
     "timers": "fake",
     "setupFiles": [
       "<rootDir>/scripts/setupJest.js"
-    ],
-    "unmockedModulePathPatterns": [
-      "promise",
-      "source-map",
-      "denodeify",
-      "fbjs",
-      "sinon",
-      "core-js"
     ]
   }
 }

packages/metro-bundler/src/AssetServer/__tests__/AssetServer-test.js

@@ -9,8 +9,6 @@
 
 'use strict';
 
-jest.disableAutomock();
-
 jest.mock('fs');
 
 const AssetServer = require('../');

packages/metro-bundler/src/Bundler/__tests__/Bundle-test.js

@@ -10,8 +10,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const Bundle = require('../Bundle');
 const ModuleTransport = require('../../lib/ModuleTransport');
 const crypto = require('crypto');

packages/metro-bundler/src/Bundler/__tests__/Bundler-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 jest
   .setMock('worker-farm', () => () => undefined)
   .setMock('../../worker-farm', () => () => undefined)

packages/metro-bundler/src/Bundler/source-map/__tests__/B64Builder-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const B64Builder = require('../B64Builder');
 
 let builder;

packages/metro-bundler/src/Bundler/source-map/__tests__/Generator-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const Generator = require('../Generator');
 
 const {objectContaining} = expect;

packages/metro-bundler/src/Bundler/source-map/__tests__/source-map-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const Generator = require('../Generator');
 const {compactMapping, fromRawMappings} = require('..');
 

packages/metro-bundler/src/JSTransformer/__tests__/Transformer-test.js

@@ -9,18 +9,10 @@
 'use strict';
 
 jest
-  .unmock('stream')
+  .mock('fs', () => ({writeFileSync: jest.fn()}))
-  .unmock('crypto')
+  .mock('temp', () => ({path: () => '/arbitrary/path'}))
-  .unmock('../../lib/ModuleTransport')
+  .mock('worker-farm', () => jest.fn())
-  .unmock('../');
+  .mock('../../worker-farm', () => jest.fn());
-
-const fs = {writeFileSync: jest.fn()};
-const temp = {path: () => '/arbitrary/path'};
-const workerFarm = jest.fn();
-jest.setMock('fs', fs);
-jest.setMock('temp', temp);
-jest.setMock('worker-farm', workerFarm);
-jest.setMock('../../worker-farm', workerFarm);
 
 var Transformer = require('../');
 
@@ -37,6 +29,8 @@ describe('Transformer', function() {
     Cache = jest.fn();
     Cache.prototype.get = jest.fn((a, b, c) => c());
 
+    const fs = require('fs');
+    const workerFarm = require('../../worker-farm');
     fs.writeFileSync.mockClear();
     workerFarm.mockClear();
     workerFarm.mockImplementation((opts, path, methods) => {

packages/metro-bundler/src/JSTransformer/worker/__tests__/constant-folding-test.js

@@ -8,7 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
 const babel = require('babel-core');
 const constantFolding = require('../constant-folding');
 

packages/metro-bundler/src/JSTransformer/worker/__tests__/extract-dependencies-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const extractDependencies = require('../extract-dependencies');
 
 describe('Dependency extraction:', () => {

packages/metro-bundler/src/JSTransformer/worker/__tests__/inline-test.js

@@ -10,7 +10,6 @@
 
 /* eslint-disable max-len */
 
-jest.disableAutomock();
 const inline = require('../inline');
 const {transform, transformFromAst} = require('babel-core');
 

packages/metro-bundler/src/JSTransformer/worker/__tests__/minify-test.js

@@ -8,17 +8,14 @@
  */
 'use strict';
 
-jest.disableAutomock();
+jest.mock('uglify-js', () => ({
-
-const uglify = {
   minify: jest.fn(code => {
     return {
       code: code.replace(/(^|\W)\s+/g, '$1'),
       map: {},
     };
   }),
-};
+}));
-jest.setMock('uglify-js', uglify);
 
 const minify = require('../minify');
 const {objectContaining} = jasmine;
@@ -27,8 +24,10 @@ describe('Minification:', () => {
   const filename = '/arbitrary/file.js';
   const code = 'arbitrary(code)';
   let map;
+  let uglify;
 
   beforeEach(() => {
+    uglify = require('uglify-js');
     uglify.minify.mockClear();
     uglify.minify.mockReturnValue({code: '', map: '{}'});
     map = {version: 3, sources: ['?'], mappings: ''};

packages/metro-bundler/src/JSTransformer/worker/__tests__/worker-test.js

@@ -8,11 +8,10 @@
  */
 'use strict';
 
-jest.disableAutomock();
+jest.mock('../constant-folding')
-jest.mock('../constant-folding');
+  .mock('../extract-dependencies')
-jest.mock('../extract-dependencies');
+  .mock('../inline')
-jest.mock('../inline');
+  .mock('../minify');
-jest.mock('../minify');
 
 const {objectContaining} = jasmine;
 

packages/metro-bundler/src/Logger/__tests__/Logger-test.js

@@ -11,8 +11,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const {
   createEntry,
   createActionStartEntry,

packages/metro-bundler/src/ModuleGraph/__tests__/Graph-test.js

@@ -9,7 +9,6 @@
 'use strict';
 
 jest
-  .disableAutomock()
   .useRealTimers()
   .mock('console');
 

packages/metro-bundler/src/ModuleGraph/__tests__/ModuleGraph-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const ModuleGraph = require('../ModuleGraph');
 const defaults = require('../../defaults');
 

packages/metro-bundler/src/ModuleGraph/output/__tests__/indexed-ram-bundle-test.js

@@ -11,7 +11,6 @@
 'use strict';
 
 declare var jest: any;
-jest.disableAutomock();
 
 const indexedRamBundle = require('../indexed-ram-bundle');
 const {addModuleIdsToModuleWrapper} = require('../util');

packages/metro-bundler/src/ModuleGraph/output/__tests__/util-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const {match} = require('sinon');
 const {fn} = require('../../test-helpers');
 const {

packages/metro-bundler/src/ModuleGraph/worker/__tests__/collect-dependencies-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const collectDependencies = require('../collect-dependencies');
 const astFromCode = require('babylon').parse;
 const {codeFromAst, comparableCode} = require('../../test-helpers');

packages/metro-bundler/src/ModuleGraph/worker/__tests__/optimize-module-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const optimizeModule = require('../optimize-module');
 const transformModule = require('../transform-module');
 const transformer = require('../../../transformer.js');

packages/metro-bundler/src/ModuleGraph/worker/__tests__/transform-module-test.js

@@ -10,8 +10,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const transformModule = require('../transform-module');
 
 const t = require('babel-types');

packages/metro-bundler/src/ModuleGraph/worker/__tests__/wrap-worker-fn-test.js

@@ -9,8 +9,7 @@
 'use strict';
 
 jest
-  .disableAutomock()
+  .mock('fs', () => jest.genMockFromModule('fs'))
-  .setMock('fs', jest.genMockFromModule('fs'))
   .mock('mkdirp');
 
 const wrapWorkerFn = require('../wrap-worker-fn');

packages/metro-bundler/src/Resolver/__tests__/Resolver-test.js

@@ -10,8 +10,6 @@
 
 jest.useRealTimers();
 
-jest.unmock('../');
-jest.unmock('../../defaults');
 jest.mock('path');
 
 const {join: pathJoin} = require.requireActual('path');

packages/metro-bundler/src/Resolver/polyfills/__tests__/Object.es7-test.js

@@ -13,8 +13,6 @@
 
 'use strict';
 
-jest.disableAutomock();
-
 describe('Object (ES7)', () => {
   beforeEach(() => {
     delete Object.entries;

packages/metro-bundler/src/Server/__tests__/MultipartResponse-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.dontMock('../MultipartResponse');
-
 const MultipartResponse = require('../MultipartResponse');
 
 describe('MultipartResponse', () => {

packages/metro-bundler/src/Server/__tests__/Server-test.js

@@ -9,8 +9,6 @@
 
 'use strict';
 
-jest.disableAutomock();
-
 jest.mock('../../worker-farm', () => () => () => {})
     .mock('worker-farm', () => () => () => {})
     .mock('timers', () => ({setImmediate: fn => setTimeout(fn, 0)}))

packages/metro-bundler/src/Server/symbolicate/__tests__/symbolicate-test.js

@@ -8,9 +8,8 @@
  */
 'use strict';
 
-jest.disableAutomock();
+jest.mock('child_process')
-jest.mock('child_process');
+  .mock('net');
-jest.mock('net');
 
 const EventEmitter = require('events');
 const {Readable} = require('stream');

packages/metro-bundler/src/Server/symbolicate/__tests__/util-test.js

@@ -9,8 +9,6 @@
 
 'use strict';
 
-jest.disableAutomock();
-
 const {LazyPromise, LockingPromise} = require('../util');
 
 describe('Lazy Promise', () => {

packages/metro-bundler/src/Server/symbolicate/__tests__/worker-test.js

@@ -10,8 +10,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
-
 const SourceMapGenerator = require('../../../Bundler/source-map/Generator');
 const {symbolicate} = require('../worker');
 

packages/metro-bundler/src/integration_tests/__tests__/basic_bundle-test.js

@@ -11,11 +11,9 @@
 
 'use strict';
 
-jest.disableAutomock();
+jest.useRealTimers()
-jest.useRealTimers();
+  .unmock('fs')
-
+  .unmock('graceful-fs');
-jest.dontMock('fs');
-jest.dontMock('graceful-fs');
 
 /**
  * Don't waste time creating a worker-farm from jest-haste-map, use the function

packages/metro-bundler/src/lib/__tests__/BatchProcessor-test.js

@@ -9,9 +9,7 @@
 
 'use strict';
 
-jest
+jest.useRealTimers();
-  .useRealTimers()
-  .dontMock('../BatchProcessor');
 
 const BatchProcessor = require('../BatchProcessor');
 

packages/metro-bundler/src/lib/__tests__/GlobalTransformCache-test.js

@@ -9,7 +9,6 @@
 
 'use strict';
 
-jest.disableAutomock();
 jest.useRealTimers();
 
 const mockFetch = jest.fn();

packages/metro-bundler/src/lib/__tests__/TerminalClass-test.js

@@ -9,8 +9,6 @@
 
 'use strict';
 
-jest.dontMock('../TerminalClass').dontMock('lodash/throttle');
-
 jest.mock('readline', () => ({
   moveCursor: (stream, dx, dy) => {
     const {cursor, columns} = stream;

packages/metro-bundler/src/lib/__tests__/TransformCaching-test.js

@@ -9,13 +9,6 @@
 
 'use strict';
 
-jest
-  .dontMock('json-stable-stringify')
-  .dontMock('../TransformCaching')
-  .dontMock('left-pad')
-  .dontMock('lodash/throttle')
-  .dontMock('crypto');
-
 const crypto = require('crypto');
 const jsonStableStringify = require('json-stable-stringify');
 
@@ -32,6 +25,7 @@ jest.mock('fs', () => ({
     // Not required for it to work.
     return [];
   },
+  mkdirSync: jest.fn(),
 }));
 
 jest.mock('write-file-atomic', () => ({

packages/metro-bundler/src/node-haste/__tests__/AssetModule-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.autoMockOff();
-
 const AssetModule = require('../AssetModule');
 
 describe('AssetModule:', () => {

packages/metro-bundler/src/node-haste/__tests__/AssetResolutionCache-test.js

@@ -11,8 +11,6 @@
 
 'use strict';
 
-jest.disableAutomock();
-
 const AssetResolutionCache = require('../AssetResolutionCache');
 
 const MOCK_FILE_NAMES = [

packages/metro-bundler/src/node-haste/__tests__/DependencyGraph-test.js

@@ -10,7 +10,6 @@
  */
 'use strict';
 
-jest.disableAutomock();
 jest.useRealTimers();
 jest
   .mock('fs')

packages/metro-bundler/src/node-haste/__tests__/Module-test.js

@@ -8,21 +8,18 @@
  */
 'use strict';
 
-jest
+jest.mock('fs')
-  .dontMock('absolute-path')
+  .mock('graceful-fs')
-  .dontMock('json-stable-stringify')
+  .mock('../ModuleCache')
-  .dontMock('crypto')
+  .mock('../DependencyGraph/DependencyGraphHelpers')
-  .dontMock('../DependencyGraph/docblock')
+  .mock('../../lib/TransformCaching');
-  .dontMock('../Module');
-
-jest
-  .mock('fs');
 
+console.log(require.resolve('../../lib/TransformCaching'));
 const Module = require('../Module');
 const ModuleCache = require('../ModuleCache');
 const DependencyGraphHelpers = require('../DependencyGraph/DependencyGraphHelpers');
 const TransformCaching = require('../../lib/TransformCaching');
-const fs = require('graceful-fs');
+const fs = require('fs');
 
 const packageJson =
   JSON.stringify({

packages/metro-bundler/src/node-haste/lib/__tests__/AssetPaths-test.js

@@ -8,9 +8,6 @@
  */
 'use strict';
 
-jest.dontMock('../parsePlatformFilePath')
-    .dontMock('../AssetPaths');
-
 var AssetPaths = require('../AssetPaths');
 
 const TEST_PLATFORMS = new Set(['ios', 'android']);

packages/metro-bundler/src/node-haste/lib/__tests__/MapWithDefaults-test.js

@@ -11,8 +11,6 @@
 
 'use strict';
 
-jest.disableAutomock();
-
 const MapWithDefaults = require('../MapWithDefaults');
 
 describe('MapWithDefaults', function() {

packages/metro-bundler/src/node-haste/lib/__tests__/parsePlatformFilePath-test.js

@@ -8,8 +8,6 @@
  */
 'use strict';
 
-jest.dontMock('../parsePlatformFilePath');
-
 var parsePlatformFilePath = require('../parsePlatformFilePath');
 
 const TEST_PLATFORMS = new Set(['ios', 'android']);