From 50220f1384c8a1688d90e9408c631191d65b0896 Mon Sep 17 00:00:00 2001 From: Amjad Masad Date: Fri, 6 Mar 2015 14:11:18 -0800 Subject: [PATCH] [react-packager] dev option needs to default to true for backwards compat --- react-packager/src/Server/index.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/react-packager/src/Server/index.js b/react-packager/src/Server/index.js index 053aa033..a918662e 100644 --- a/react-packager/src/Server/index.js +++ b/react-packager/src/Server/index.js @@ -196,7 +196,7 @@ function getOptionsFromUrl(reqUrl) { return { sourceMapUrl: urlObj.pathname.replace(/\.bundle$/, '.map'), main: main, - dev: getBoolOptionFromQuery(urlObj.query, 'dev'), + dev: getBoolOptionFromQuery(urlObj.query, 'dev', true), minify: getBoolOptionFromQuery(urlObj.query, 'minify'), runModule: getBoolOptionFromQuery(urlObj.query, 'runModule') || // Backwards compatibility. @@ -206,7 +206,11 @@ function getOptionsFromUrl(reqUrl) { }; } -function getBoolOptionFromQuery(query, opt) { +function getBoolOptionFromQuery(query, opt, defaultVal) { + if (query[opt] == null && defaultVal != null) { + return defaultVal; + } + return query[opt] === 'true' || query[opt] === '1'; }