status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

packager: react-packager.js: reinforce the typing at API boundary 

Reviewed By: davidaurelio

Differential Revision: D4698256

fbshipit-source-id: 7a42e9b79744f599e92b5d3d91c41cdd0de2ece5
This commit is contained in:
Jean Lauliac 2017-03-14 11:01:19 -07:00 committed by Facebook Github Bot
parent 915ab18d53
commit 2f208f714a
1 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
packages/metro-bundler/react-packager.js vendored
View File

@ -16,6 +16,7 @@ const Logger = require('./src/Logger');
const debug = require('debug'); const debug = require('debug');
const invariant = require('fbjs/lib/invariant'); const invariant = require('fbjs/lib/invariant');
import type Server from './src/Server';
import type GlobalTransformCache from './src/lib/GlobalTransformCache'; import type GlobalTransformCache from './src/lib/GlobalTransformCache';
import type {Reporter} from './src/lib/reporting'; import type {Reporter} from './src/lib/reporting';
import type {HasteImpl} from './src/node-haste/Module'; import type {HasteImpl} from './src/node-haste/Module';
@ -41,9 +42,27 @@ type StrictOptions = {
watch?: boolean, watch?: boolean,
}; };
exports.buildBundle = function(options: Options, bundleOptions: {}) { /**
* This is a public API, so we don't trust the values and consider them as
* `mixed`. Because it understands `invariant`, Flow ensure that we refine these
* values completely.
*/
exports.buildBundle = function(options: Options, bundleOptions: mixed) {
invariant(
typeof bundleOptions === 'object' && bundleOptions != null,
'`bundleOptions` must be an object',
);
const {entryFile, platform} = bundleOptions;
invariant(
platform === undefined || typeof platform === 'string',
'`bundleOptions` field `platform` must be a string',
);
invariant(
typeof entryFile === 'string',
'`bundleOptions` must contain a string field `entryFile`',
);
var server = createNonPersistentServer(options); var server = createNonPersistentServer(options);
return server.buildBundle(bundleOptions) return server.buildBundle({...bundleOptions, entryFile, platform})
.then(p => { .then(p => {
server.end(); server.end();
return p; return p;
@ -73,7 +92,7 @@ function enableDebug() {
debug.enable(debugPattern); debug.enable(debugPattern);
} }
function createServer(options: StrictOptions) { function createServer(options: StrictOptions): Server {
// the debug module is configured globally, we need to enable debugging // the debug module is configured globally, we need to enable debugging
// *before* requiring any packages that use `debug` for logging // *before* requiring any packages that use `debug` for logging
if (options.verbose) { if (options.verbose) {
@ -84,11 +103,11 @@ function createServer(options: StrictOptions) {
invariant(options.reporter != null, 'createServer() requires reporter'); invariant(options.reporter != null, 'createServer() requires reporter');
const serverOptions = Object.assign({}, options); const serverOptions = Object.assign({}, options);
delete serverOptions.verbose; delete serverOptions.verbose;
var Server = require('./src/Server'); const ServerClass = require('./src/Server');
return new Server(serverOptions); return new ServerClass(serverOptions);
} }
function createNonPersistentServer(options: Options) { function createNonPersistentServer(options: Options): Server {
const serverOptions = { const serverOptions = {
// It's unsound to set-up the reporter here, // It's unsound to set-up the reporter here,
// but this allows backward compatibility. // but this allows backward compatibility.