From 279f11a34401af53b53f61b0fc704041146559cc Mon Sep 17 00:00:00 2001
From: David Aurelio <davidaurelio@fb.com>
Date: Fri, 13 Jan 2017 10:28:39 -0800
Subject: [PATCH] Fix loading minified bundle over HTTP

Summary: Sets `generateSourceMaps` to true when requesting a bundle in non-dev mode or minified.

Reviewed By: bestander, cpojer

Differential Revision: D4415492

fbshipit-source-id: 9b4dcbd577a535dab143bb7a067210fbd831bf1a
---
 react-packager/src/Server/__tests__/Server-test.js | 2 +-
 react-packager/src/Server/index.js                 | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/react-packager/src/Server/__tests__/Server-test.js b/react-packager/src/Server/__tests__/Server-test.js
index 9ffe900d..bcfb2cfc 100644
--- a/react-packager/src/Server/__tests__/Server-test.js
+++ b/react-packager/src/Server/__tests__/Server-test.js
@@ -442,7 +442,7 @@ describe('processRequest', () => {
             entryFile: 'path/to/foo.js',
             inlineSourceMap: false,
             minify: false,
-            generateSourceMaps: false,
+            generateSourceMaps: true,
             hot: false,
             runModule: false,
             sourceMapUrl: '/path/to/foo.map?dev=false&runModule=false',
diff --git a/react-packager/src/Server/index.js b/react-packager/src/Server/index.js
index f6276aff..a87cb9b3 100644
--- a/react-packager/src/Server/index.js
+++ b/react-packager/src/Server/index.js
@@ -926,11 +926,13 @@ class Server {
       assetPlugin :
       (typeof assetPlugin === 'string') ? [assetPlugin] : [];
 
+    const dev = this._getBoolOptionFromQuery(urlObj.query, 'dev', true);
+    const minify = this._getBoolOptionFromQuery(urlObj.query, 'minify', false);
     return {
       sourceMapUrl: url.format(sourceMapUrlObj),
       entryFile: entryFile,
-      dev: this._getBoolOptionFromQuery(urlObj.query, 'dev', true),
-      minify: this._getBoolOptionFromQuery(urlObj.query, 'minify', false),
+      dev,
+      minify,
       hot: this._getBoolOptionFromQuery(urlObj.query, 'hot', false),
       runModule: this._getBoolOptionFromQuery(urlObj.query, 'runModule', true),
       inlineSourceMap: this._getBoolOptionFromQuery(
@@ -944,7 +946,7 @@ class Server {
         'entryModuleOnly',
         false,
       ),
-      generateSourceMaps: this._getBoolOptionFromQuery(urlObj.query, 'babelSourcemap', false),
+      generateSourceMaps: minify || !dev || this._getBoolOptionFromQuery(urlObj.query, 'babelSourcemap', false),
       assetPlugins,
     };
   }