status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Prevent unnecessary deserialize/serialize of sourcemap 

Summary: This prevents unnecessary JSON.stringify/JSON.parse when the operation is noop anyways.

Reviewed By: mjesun

Differential Revision: D6884246

fbshipit-source-id: 3370caac1e01cb79f86af95f0dd06285150c5d95
This commit is contained in:
Peter van der Zee 2018-02-05 00:59:23 -08:00 committed by Facebook Github Bot
parent 79fd0b341e
commit 23e4d7abae
1 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/metro/src/shared/output/bundle.js
View File

@ -34,19 +34,15 @@ function buildBundle(
}
function createCodeWithMap(
bundle: {code: string, map: string},
map: string,
dev: boolean,
sourceMapSourcesRoot?: string,
): {code: string, map: MetroSourceMap} {
const map = bundle.map;
sourceMapSourcesRoot: string,
): string {
const sourceMap = relativizeSourceMap(
(JSON.parse(map): MetroSourceMap),
sourceMapSourcesRoot,
);
return {
code: bundle.code,
map: sourceMap,
};
return JSON.stringify(sourceMap);
}
function saveBundleAndMap(
@ -62,13 +58,16 @@ function saveBundleAndMap(
sourcemapSourcesRoot,
} = options;
log('start');
const codeWithMap = createCodeWithMap(bundle, !!dev, sourcemapSourcesRoot);
log('finish');
let {map} = bundle;
if (sourcemapSourcesRoot !== undefined) {
log('start');
map = createCodeWithMap(map, !!dev, sourcemapSourcesRoot);
log('finish');
}
log('Writing bundle output to:', bundleOutput);
const {code} = codeWithMap;
const {code} = bundle;
const writeBundle = writeFile(bundleOutput, code, encoding);
const writeMetadata = writeFile(
bundleOutput + '.meta',
@ -81,10 +80,6 @@ function saveBundleAndMap(
if (sourcemapOutput) {
log('Writing sourcemap output to:', sourcemapOutput);
const map =
typeof codeWithMap.map !== 'string'
? JSON.stringify(codeWithMap.map)
: codeWithMap.map;
const writeMap = writeFile(sourcemapOutput, map, null);
writeMap.then(() => log('Done writing sourcemap output'));
return Promise.all([writeBundle, writeMetadata, writeMap]);