status-im/metro
2
0
Fork 0
mirror of https://github.com/status-im/metro.git synced 2025-03-02 03:30:53 +00:00
Code Issues Projects Releases Wiki Activity

Always report filename

Browse Source 
Reviewed By: cpojer

Differential Revision: D5764824

fbshipit-source-id: cb90e429176764d4a1043fd57bbfee223361a182
This commit is contained in:
Miguel Jimenez Esun 2017-09-04 13:39:18 -07:00 committed by Facebook Github Bot
parent 6e415bcb2f
commit 2377f04f4a
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/metro-bundler/src/JSTransformer/__tests__/Transformer-test.js
View File

@ -6,6 +6,7 @@
* LICENSE file in the root directory of this source tree. An additional grant * LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory. * of patent rights can be found in the PATENTS file in the same directory.
* *
* @emails oncall+javascript_tools
* @format * @format
*/ */
'use strict'; 'use strict';
@ -100,7 +101,9 @@ describe('Transformer', function() {
.transformFile(fileName, localPath, '', {}) .transformFile(fileName, localPath, '', {})
.catch(function(error) { .catch(function(error) {
expect(error.type).toEqual('TransformError'); expect(error.type).toEqual('TransformError');
expect(error.message).toBe('SyntaxError ' + message); expect(error.message).toBe(
'SyntaxError in /an/arbitrary/file.js: ' + message,
);
expect(error.lineNumber).toBe(2); expect(error.lineNumber).toBe(2);
expect(error.column).toBe(15); expect(error.column).toBe(15);
expect(error.filename).toBe(fileName); expect(error.filename).toBe(fileName);

2
packages/metro-bundler/src/JSTransformer/index.js
View File

@ -224,7 +224,7 @@ function formatGenericError(err, filename) {
function formatBabelError(err, filename) { function formatBabelError(err, filename) {
var error = new TransformError(); var error = new TransformError();
error.type = 'TransformError'; error.type = 'TransformError';
error.message = (err.type || error.type) + ' ' + err.message; error.message = `${err.type || error.type} in ${filename}: ${err.message}`;
error.stack = err.stack; error.stack = err.stack;
error.snippet = err.codeFrame; error.snippet = err.codeFrame;
error.lineNumber = err.loc.line; error.lineNumber = err.loc.line;