From 1b898cba22a5748c719ecf7bcaf5a8cfb04ff8ec Mon Sep 17 00:00:00 2001 From: Jean Lauliac Date: Thu, 23 Mar 2017 12:25:37 -0700 Subject: [PATCH] packager: TerminalReporter: stop reporting global cache errors Summary: At FB we log errors into the error infra, and these errors are not actionnable for end users, so let's reduce the noise generated on the terminal. In the OSS case, people can simply add a handler in a TerminalReporter decorator, the same way we do internally (anyhow, I do not know of anyone using the global cache in OSS for now). Reviewed By: davidaurelio Differential Revision: D4762858 fbshipit-source-id: 880c02e175ae551df11b7ce273acc318222c46bf --- packages/metro-bundler/src/lib/TerminalReporter.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/metro-bundler/src/lib/TerminalReporter.js b/packages/metro-bundler/src/lib/TerminalReporter.js index 58500faa..7f63d3b7 100644 --- a/packages/metro-bundler/src/lib/TerminalReporter.js +++ b/packages/metro-bundler/src/lib/TerminalReporter.js @@ -148,10 +148,6 @@ class TerminalReporter { case 'dep_graph_loaded': terminal.log(`${DEP_GRAPH_MESSAGE}, done.`); break; - case 'global_cache_error': - const message = JSON.stringify(event.error.message); - reporting.logWarning(terminal, 'the global cache failed: %s', message); - break; case 'global_cache_disabled': this._logCacheDisabled(event.reason); break;