From 1a2a46a9fb3e3af2089c06ce7a25dbcd8737201b Mon Sep 17 00:00:00 2001 From: Rafael Oleza Date: Wed, 18 Oct 2017 12:17:12 -0700 Subject: [PATCH] Always set the runBeforeMainModule bundle param on buildBundle() Summary: This diff fixes https://github.com/facebook/metro-bundler/issues/78 by adding the `runBeforeMainModule` server parameter to the bundler. This is not the cleanest solution, but will be fixed once we use the Delta Bundler for builds from the CLI Reviewed By: davidaurelio Differential Revision: D6074469 fbshipit-source-id: 068926ef671d9f897ad9f1bd0540036a97340c00 --- packages/metro-bundler/src/Server/__tests__/Server-test.js | 2 +- packages/metro-bundler/src/Server/index.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/metro-bundler/src/Server/__tests__/Server-test.js b/packages/metro-bundler/src/Server/__tests__/Server-test.js index 178dd212..10eb8395 100644 --- a/packages/metro-bundler/src/Server/__tests__/Server-test.js +++ b/packages/metro-bundler/src/Server/__tests__/Server-test.js @@ -537,7 +537,7 @@ describe('processRequest', () => { onProgress: null, platform: undefined, resolutionResponse: null, - runBeforeMainModule: [], + runBeforeMainModule: ['InitializeCore'], runModule: true, sourceMapUrl: null, unbundle: false, diff --git a/packages/metro-bundler/src/Server/index.js b/packages/metro-bundler/src/Server/index.js index f74072da..e0c86d91 100644 --- a/packages/metro-bundler/src/Server/index.js +++ b/packages/metro-bundler/src/Server/index.js @@ -324,7 +324,10 @@ class Server { } async buildBundle(options: BundleOptions): Promise { - const bundle = await this._bundler.bundle(options); + const bundle = await this._bundler.bundle({ + ...options, + runBeforeMainModule: this._opts.runBeforeMainModule, + }); const modules = bundle.getModules(); const nonVirtual = modules.filter(m => !m.virtual); bundleDeps.set(bundle, {