Revert "Install playwright in the base image so it is cached (#226)" (#231)

* Revert "Install playwright in the base image so it is cached (#226)"

This reverts commit d21d042ddd.

* Add comment
This commit is contained in:
Marco Munizaga 2023-07-14 11:48:08 -07:00 committed by GitHub
parent e69e155fe9
commit 4bd0f9992f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions

View File

@ -11,6 +11,10 @@ FROM mcr.microsoft.com/playwright
COPY --from=js-libp2p-base /app/ /app/
WORKDIR /app/interop
# We install browsers here instead of the cached version so that we use the latest browsers at run time.
# Ideally this would also be pinned, but playwright controls this, so there isn't much we can do about it.
# By installing here, we avoid installing it at test time.
RUN ./node_modules/.bin/playwright install
ARG BROWSER=chromium # Options: chromium, firefox, webkit
ENV BROWSER=$BROWSER

View File

@ -7,6 +7,5 @@ RUN npm i && npm run build
WORKDIR /app/interop
RUN npm i && npm run build
RUN ./node_modules/.bin/playwright install
ENTRYPOINT [ "npm", "test", "--", "--build", "false", "--types", "false", "-t", "node" ]