Merge pull request #1 from richard-ramos/fix/giftbucket-init

initialize GiftBucket in Proxy constructor
This commit is contained in:
Andrea Franz 2020-02-24 15:26:36 +01:00 committed by GitHub
commit 76cb481b50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 8 deletions

View File

@ -13,13 +13,9 @@ contract GiftBucketFactory {
}
function create(address _tokenAddress, uint256 _expirationTime) public returns (address) {
address p = address(new Proxy("", address(GiftBucketImplementation)));
GiftBucket g = GiftBucket(p);
g.initialize(_tokenAddress, _expirationTime, msg.sender);
emit Created(msg.sender, address(p));
return address(p);
// initialize(address,uint256,address)
address p = address(new Proxy(abi.encodeWithSelector(0xc350a1b5, _tokenAddress, _expirationTime, msg.sender), address(GiftBucketImplementation)));
emit Created(msg.sender, p);
return p;
}
}