From c5302fd0c855259f30c0e5eea9c5a26f78fe3795 Mon Sep 17 00:00:00 2001 From: fbarbu15 Date: Thu, 30 May 2024 18:59:16 +0300 Subject: [PATCH] remove try catch no longer needed after 1790 got fixed (#2026) --- .../tests/tests/filter/subscribe.node.spec.ts | 28 +++++++------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/packages/tests/tests/filter/subscribe.node.spec.ts b/packages/tests/tests/filter/subscribe.node.spec.ts index 052108b87b..fe6e024d2f 100644 --- a/packages/tests/tests/filter/subscribe.node.spec.ts +++ b/packages/tests/tests/filter/subscribe.node.spec.ts @@ -309,25 +309,17 @@ const runTests = (strictCheckNodes: boolean): void => { }); } - // Open issue here: https://github.com/waku-org/js-waku/issues/1790 - // That's why we use the try catch block - try { - // Verify that each message was received on the corresponding topic. - expect( - await serviceNodes.messageCollector.waitForMessages(topicCount) - ).to.eq(true); - td.contentTopics.forEach((topic, index) => { - serviceNodes.messageCollector.verifyReceivedMessage(index, { - expectedContentTopic: topic, - expectedMessageText: `Message for Topic ${index + 1}`, - expectedPubsubTopic: TestPubsubTopic - }); + // Verify that each message was received on the corresponding topic. + expect( + await serviceNodes.messageCollector.waitForMessages(topicCount) + ).to.eq(true); + td.contentTopics.forEach((topic, index) => { + serviceNodes.messageCollector.verifyReceivedMessage(index, { + expectedContentTopic: topic, + expectedMessageText: `Message for Topic ${index + 1}`, + expectedPubsubTopic: TestPubsubTopic }); - } catch (error) { - console.warn( - "This test still fails because of https://github.com/waku-org/js-waku/issues/1790" - ); - } + }); }); it("Error when try to subscribe to more than 101 topics (new limit)", async function () {