status-im
/
js-waku
mirror of https://github.com/status-im/js-waku.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: increasing maxInboundStreams for lightpush from 32 to 100 (#2021) 

* increasing maxInboundStreams for lightpush from 32 to 100

* allowing test to fail
This commit is contained in:
gabrielmer 2024-05-30 10:28:50 +02:00 committed by GitHub
parent e49e7289ae
commit 2311a595b2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/core/src/lib/filter/index.ts
View File

@ -48,9 +48,13 @@ export class FilterCore extends BaseProtocol implements IBaseProtocolCore {
options options
); );
libp2p.handle(FilterCodecs.PUSH, this.onRequest.bind(this)).catch((e) => { libp2p
log.error("Failed to register ", FilterCodecs.PUSH, e); .handle(FilterCodecs.PUSH, this.onRequest.bind(this), {
}); maxInboundStreams: 100
})
.catch((e) => {
log.error("Failed to register ", FilterCodecs.PUSH, e);
});
} }
private onRequest(streamData: IncomingStreamData): void { private onRequest(streamData: IncomingStreamData): void {

24
packages/tests/tests/filter/single_node/subscribe.node.spec.ts
View File

@ -262,23 +262,15 @@ describe("Waku Filter V2: Subscribe: Single Service Node", function () {
}); });
} }
// Open issue here: https://github.com/waku-org/js-waku/issues/1790 // Verify that each message was received on the corresponding topic.
// That's why we use the try catch block expect(await messageCollector.waitForMessages(topicCount)).to.eq(true);
try { td.contentTopics.forEach((topic, index) => {
// Verify that each message was received on the corresponding topic. messageCollector.verifyReceivedMessage(index, {
expect(await messageCollector.waitForMessages(topicCount)).to.eq(true); expectedContentTopic: topic,
td.contentTopics.forEach((topic, index) => { expectedMessageText: `Message for Topic ${index + 1}`,
messageCollector.verifyReceivedMessage(index, { expectedPubsubTopic: TestPubsubTopic
expectedContentTopic: topic,
expectedMessageText: `Message for Topic ${index + 1}`,
expectedPubsubTopic: TestPubsubTopic
});
}); });
} catch (error) { });
console.warn(
"This test still fails because of https://github.com/waku-org/js-waku/issues/1790"
);
}
}); });
it("Error when try to subscribe to more than 101 topics (new limit)", async function () { it("Error when try to subscribe to more than 101 topics (new limit)", async function () {