status-im/instabug-reactnative
2
0
Fork 0
mirror of https://github.com/status-im/instabug-reactnative.git synced 2025-03-03 14:40:54 +00:00
Code Issues Projects Releases Wiki Activity

🤝 Merge pull request #99 from Instabug/hotfix/fix_link_script_if_condition

Browse Source 
📝 Update script to add brackets to if condition as it did not get eva…
This commit is contained in:
salmatarzi 2017-12-05 11:43:06 +02:00 committed by GitHub
commit e79aa9eee2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 53 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
link.rb
View File

@ -26,49 +26,48 @@ project = Xcodeproj::Project.open(project_location)
frameworks_group = project.groups.find { |group| group.display_name == 'Frameworks' } frameworks_group = project.groups.find { |group| group.display_name == 'Frameworks' }
frameworks_group ||= project.new_group('Frameworks') frameworks_group ||= project.new_group('Frameworks')
default_target = project.targets.find { |target| target.to_s == default_target_name } default_target = project.targets.find { |target| target.to_s == default_target_name }
targets = project.targets targets = project.targets.select { |target| (target.is_a? Xcodeproj::Project::Object::PBXNativeTarget) &&
(target.product_type == "com.apple.product-type.application") &&
(target.platform_name == :ios) }
framework_ref = frameworks_group.new_file("#{framework_root}/#{framework_name}") framework_ref = frameworks_group.new_file("#{framework_root}/#{framework_name}")
# Add Instabug to every target that is of type application # Add Instabug to every target that is of type application
targets.each do |target| targets.each do |target|
if target.is_a? Xcodeproj::Project::Object::PBXNativeTarget && (target.product_type == "com.apple.product-type.application") && (target.platform_name == :ios) # Add new "Embed Frameworks" build phase to target
embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Instabug Framework'}
Kernel.exit(0) if embed_frameworks_build_phase
embed_frameworks_build_phase = project.new(Xcodeproj::Project::Object::PBXCopyFilesBuildPhase)
embed_frameworks_build_phase.name = 'Embed Instabug Framework'
embed_frameworks_build_phase.symbol_dst_subfolder_spec = :frameworks
target.build_phases << embed_frameworks_build_phase
# Add new "Embed Frameworks" build phase to target # Add static library to non default targets' build phase
embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Instabug Framework'} if target.name != default_target_name
Kernel.exit(0) if embed_frameworks_build_phase static_library_file_reference = default_target.frameworks_build_phase.files_references.find { |file_reference| file_reference.path == 'libRNInstabug.a' }
embed_frameworks_build_phase = project.new(Xcodeproj::Project::Object::PBXCopyFilesBuildPhase) target.frameworks_build_phase.add_file_reference(static_library_file_reference)
embed_frameworks_build_phase.name = 'Embed Instabug Framework'
embed_frameworks_build_phase.symbol_dst_subfolder_spec = :frameworks
target.build_phases << embed_frameworks_build_phase
# Add static library to non default targets' build phase
if target.name != default_target_name
static_library_file_reference = default_target.frameworks_build_phase.files_references.find { |file_reference| file_reference.path == 'libRNInstabug.a' }
target.frameworks_build_phase.add_file_reference(static_library_file_reference)
end
# Add framework search path to target
target.build_configurations.each do |config|
framework_search_paths = target.build_settings(config.name)['FRAMEWORK_SEARCH_PATHS']
framework_search_paths ||= ['$(inherited)']
framework_search_paths = [framework_search_paths] unless framework_search_paths.is_a?(Array)
framework_search_paths << framework_root unless framework_search_paths.include? framework_root
target.build_settings(config.name)['FRAMEWORK_SEARCH_PATHS'] = framework_search_paths
end
# Add framework to target as "Embedded Frameworks"
build_file = embed_frameworks_build_phase.add_file_reference(framework_ref)
target.frameworks_build_phase.add_file_reference(framework_ref)
build_file.settings = { 'ATTRIBUTES' => ['CodeSignOnCopy', 'RemoveHeadersOnCopy'] }
#Add New Run Script Phase to Build Phases
phase = target.new_shell_script_build_phase(INSTABUG_PHASE_NAME)
phase.shell_script = INSTABUG_PHASE_SCRIPT
end end
# Add framework search path to target
target.build_configurations.each do |config|
framework_search_paths = target.build_settings(config.name)['FRAMEWORK_SEARCH_PATHS']
framework_search_paths ||= ['$(inherited)']
framework_search_paths = [framework_search_paths] unless framework_search_paths.is_a?(Array)
framework_search_paths << framework_root unless framework_search_paths.include? framework_root
target.build_settings(config.name)['FRAMEWORK_SEARCH_PATHS'] = framework_search_paths
end
# Add framework to target as "Embedded Frameworks"
build_file = embed_frameworks_build_phase.add_file_reference(framework_ref)
target.frameworks_build_phase.add_file_reference(framework_ref)
build_file.settings = { 'ATTRIBUTES' => ['CodeSignOnCopy', 'RemoveHeadersOnCopy'] }
#Add New Run Script Phase to Build Phases
phase = target.new_shell_script_build_phase(INSTABUG_PHASE_NAME)
phase.shell_script = INSTABUG_PHASE_SCRIPT
end end
# Save Xcode project # Save Xcode project

35
unlink.rb
View File

@ -19,7 +19,9 @@ INSTABUG_PHASE_NAME = "Strip Frameworks"
# Get useful variables # Get useful variables
project = Xcodeproj::Project.open(project_location) project = Xcodeproj::Project.open(project_location)
frameworks_group = project.groups.find { |group| group.display_name == 'Frameworks' } frameworks_group = project.groups.find { |group| group.display_name == 'Frameworks' }
targets = project.targets targets = project.targets.select { |target| (target.is_a? Xcodeproj::Project::Object::PBXNativeTarget) &&
(target.product_type == "com.apple.product-type.application") &&
(target.platform_name == :ios) }
framework_ref = frameworks_group.files.find { |file_reference| file_reference.path == "#{framework_root}/#{framework_name}"} framework_ref = frameworks_group.files.find { |file_reference| file_reference.path == "#{framework_root}/#{framework_name}"}
# Remove Instabug's framework from the Frameworks group # Remove Instabug's framework from the Frameworks group
@ -27,25 +29,22 @@ frameworks_group.children.delete(framework_ref)
# Remove Instabug to every target that is of type application # Remove Instabug to every target that is of type application
targets.each do |target| targets.each do |target|
if target.is_a? Xcodeproj::Project::Object::PBXNativeTarget && (target.product_type == "com.apple.product-type.application") && (target.platform_name == :ios) # Remove "Embed Frameworks" build phase to target
embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Instabug Framework'}
Kernel.exit(0) unless embed_frameworks_build_phase
target.build_phases.delete(embed_frameworks_build_phase)
# Remove "Embed Frameworks" build phase to target # Remove framework search path from target
embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Instabug Framework'} target.build_configurations.each do |config|
Kernel.exit(0) unless embed_frameworks_build_phase target.build_settings(config.name)['FRAMEWORK_SEARCH_PATHS'].delete(framework_root)
target.build_phases.delete(embed_frameworks_build_phase)
# Remove framework search path from target
target.build_configurations.each do |config|
target.build_settings(config.name)['FRAMEWORK_SEARCH_PATHS'].delete(framework_root)
end
# Remove framework from target from "Embedded Frameworks"
target.frameworks_build_phase.remove_file_reference(framework_ref)
#Delete New Run Script Phase from Build Phases
shell_script_build_phase = target.shell_script_build_phases.find { |build_phase| build_phase.to_s == INSTABUG_PHASE_NAME }
target.build_phases.delete(shell_script_build_phase)
end end
# Remove framework from target from "Embedded Frameworks"
target.frameworks_build_phase.remove_file_reference(framework_ref)
#Delete New Run Script Phase from Build Phases
shell_script_build_phase = target.shell_script_build_phases.find { |build_phase| build_phase.to_s == INSTABUG_PHASE_NAME }
target.build_phases.delete(shell_script_build_phase)
end end
# Save Xcode project # Save Xcode project