status-im/instabug-reactnative
2
0
Fork 0
mirror of https://github.com/status-im/instabug-reactnative.git synced 2025-03-01 13:40:42 +00:00
Code Issues Projects Releases Wiki Activity

📝 Deprecated the old setAttachmentTypesEnabled api, and made it point to the new native api

Browse Source
This commit is contained in:
Salma ElTarzi 2018-01-06 14:44:47 +02:00
parent d2cf3479e9
commit 6ae1d167a0
3 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java
View File

@ -360,7 +360,7 @@ public class RNInstabugReactnativeModule extends ReactContextBaseJavaModule {
* @param {boolean} screenRecording A boolean to enable or disable screen recording attachments.
*/
@ReactMethod
public void setAttachmentTypesEnabled(boolean screenshot, boolean extraScreenshot, boolean
public void setEnabledAttachmentTypes(boolean screenshot, boolean extraScreenshot, boolean
galleryImage, boolean screenRecording) {
try {
Instabug.setAttachmentTypesEnabled(screenshot, extraScreenshot, galleryImage,

22
index.js
View File

@ -391,6 +391,24 @@ module.exports = {
Instabug.setString(string, key);
},
/**
* @deprecated since version 2.3.0. Use {@link setEnabledAttachmentTypes} instead.
* Sets whether attachments in bug reporting and in-app messaging are enabled or not.
* @param {boolean} screenshot A boolean to enable or disable screenshot attachments.
* @param {boolean} extraScreenshot A boolean to enable or disable extra
* screenshot attachments.
* @param {boolean} galleryImage A boolean to enable or disable gallery image
* attachments. In iOS 10+,NSPhotoLibraryUsageDescription should be set in
* info.plist to enable gallery image attachments.
* @param {boolean} voiceNote A boolean to enable or disable voice note attachments.
* In iOS 10+, NSMicrophoneUsageDescription should be set in info.plist to enable
* voiceNote attachments.
* @param {boolean} screenRecording A boolean to enable or disable screen recording attachments.
*/
setAttachmentTypesEnabled: function (screenshot, extraScreenshot, galleryImage, voiceNote, screenRecording) {
Instabug.setEnabledAttachmentTypes(screenshot, extraScreenshot, galleryImage, screenRecording);
},
/**
* Sets whether attachments in bug reporting and in-app messaging are enabled or not.
* @param {boolean} screenshot A boolean to enable or disable screenshot attachments.
@ -401,8 +419,8 @@ module.exports = {
* info.plist to enable gallery image attachments.
* @param {boolean} screenRecording A boolean to enable or disable screen recording attachments.
*/
setAttachmentTypesEnabled: function (screenshot, extraScreenshot, galleryImage, screenRecording) {
Instabug.setAttachmentTypesEnabled(screenshot, extraScreenshot, galleryImage, screenRecording);
setEnabledAttachmentTypes: function (screenshot, extraScreenshot, galleryImage, screenRecording) {
Instabug.setEnabledAttachmentTypes(screenshot, extraScreenshot, galleryImage, screenRecording);
},
/**

2
ios/RNInstabug/InstabugReactBridge.m
View File

@ -184,7 +184,7 @@ RCT_EXPORT_METHOD(setString:(NSString*)value toKey:(IBGString)key) {
[Instabug setString:value toKey:key];
}
RCT_EXPORT_METHOD(setAttachmentTypesEnabled:(BOOL)screenShot
RCT_EXPORT_METHOD(setEnabledAttachmentTypes:(BOOL)screenShot
extraScreenShot:(BOOL)extraScreenShot
galleryImage:(BOOL)galleryImage
screenRecording:(BOOL)screenRecording) {