lookup_plugins/bitwarden: ignore stderr

Otherwise we get weird JSON parsing errors:
```
An unhandled exception occurred while running the lookup plugin 'bitwarden'.
Error was a <class 'json.decoder.JSONDecodeError'>, original message:
Extra data: line 1 column 843 (char 842). Extra data: line 1 column 843 (char 842)
```

Signed-off-by: Jakub Sokołowski <jakub@status.im>
This commit is contained in:
Jakub Sokołowski 2024-05-07 14:48:35 +02:00
parent 290335c75b
commit 1b4c2becf4
No known key found for this signature in database
GPG Key ID: FE65CD384D5BF7B4
1 changed files with 32 additions and 8 deletions

View File

@ -7,9 +7,11 @@
# This plugin can be run directly by specifying the field followed by a list of # This plugin can be run directly by specifying the field followed by a list of
# entries, e.g. bitwarden.py password google.com wufoo.com # entries, e.g. bitwarden.py password google.com wufoo.com
# #
# This version includes fixes that can be found in this fork: # CHANGES:
# https://github.com/status-im/ansible-modules-bitwarden # - Dropped custom_field argument
# # - Started checking sources in order
# - Refactored Bitwarden class, added get_item()
# - Split LookupModule.run into two functions
from __future__ import (absolute_import, division, print_function) from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
@ -17,7 +19,6 @@ import json
import os import os
import sys import sys
from shutil import which
from subprocess import Popen, PIPE, STDOUT, check_output from subprocess import Popen, PIPE, STDOUT, check_output
from ansible.errors import AnsibleError from ansible.errors import AnsibleError
@ -69,7 +70,9 @@ class Bitwarden(object):
def __init__(self, path): def __init__(self, path):
self._cli_path = path self._cli_path = path
self._bw_session = "" self._bw_session = ""
if which("bw") is None: try:
check_output([self._cli_path, "--version"])
except OSError:
raise AnsibleError("Command not found: {0}".format(self._cli_path)) raise AnsibleError("Command not found: {0}".format(self._cli_path))
@property @property
@ -84,12 +87,20 @@ class Bitwarden(object):
def cli_path(self): def cli_path(self):
return self._cli_path return self._cli_path
@property
def logged_in(self):
# Parse Bitwarden status to check if logged in
if self.status() == 'unlocked':
return True
else:
return False
def _run(self, args): def _run(self, args):
my_env = os.environ.copy() my_env = os.environ.copy()
if self.session != "": if self.session != "":
my_env["BW_SESSION"] = self.session my_env["BW_SESSION"] = self.session
p = Popen([self.cli_path] + args, stdin=PIPE, p = Popen([self.cli_path] + args, stdin=PIPE,
stdout=PIPE, stderr=STDOUT, env=my_env) stdout=PIPE, stderr=PIPE, env=my_env)
out, _ = p.communicate() out, _ = p.communicate()
out = out.decode() out = out.decode()
rc = p.wait() rc = p.wait()
@ -118,6 +129,13 @@ class Bitwarden(object):
def sync(self): def sync(self):
self._run(['sync']) self._run(['sync'])
def status(self):
try:
data = json.loads(self._run(['status']))
except json.decoder.JSONDecodeError as e:
raise AnsibleError("Error decoding Bitwarden status: %s" % e)
return data['status']
def get_entry(self, key, field): def get_entry(self, key, field):
return self._run(["get", field, key]) return self._run(["get", field, key])
@ -149,12 +167,18 @@ class LookupModule(LookupBase):
def run(self, terms, variables=None, **kwargs): def run(self, terms, variables=None, **kwargs):
self.bw = Bitwarden(path=kwargs.get('path', 'bw')) self.bw = Bitwarden(path=kwargs.get('path', 'bw'))
if not self.bw.logged_in:
raise AnsibleError("Not logged into Bitwarden: please run "
"'bw login', or 'bw unlock' and set the "
"BW_SESSION environment variable first")
values = []
if kwargs.get('sync'): if kwargs.get('sync'):
self.bw.sync() self.bw.sync()
if kwargs.get('session'): if kwargs.get('session'):
self.bw.session = kwargs.get('session') self.bw.session = kwargs.get('session')
values = []
for term in terms: for term in terms:
rval = self.lookup(term, kwargs) rval = self.lookup(term, kwargs)
if rval is None: if rval is None:
@ -191,7 +215,7 @@ def main():
print("Usage: %s <field> <name> [name name ...]" % os.path.basename(__file__)) print("Usage: %s <field> <name> [name name ...]" % os.path.basename(__file__))
return -1 return -1
print(LookupModule().run(sys.argv[2:], variables=None, field=sys.argv[1])) print(LookupModule().run(sys.argv[2:], variables=None, field=sys.argv[1], file='origin.crt'))
return 0 return 0