status-im/go-waku
2
0
Fork 0
mirror of https://github.com/status-im/go-waku.git synced 2025-01-15 00:04:36 +00:00
Code Issues Projects Releases Wiki Activity

fix: take into account the ENR seq to determine if a peer is new or not (#945)

Browse Source
This commit is contained in:
richΛrd 2023-12-06 09:12:48 -04:00 committed by GitHub
parent f0ed5e32d5
commit 6ab2cfb53b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
waku/v2/peermanager/peer_manager.go
View File

@ -341,9 +341,14 @@ func (pm *PeerManager) AddDiscoveredPeer(p service.PeerData, connectNow bool) {
//Check if the peer is already present, if so skip adding //Check if the peer is already present, if so skip adding
_, err := pm.host.Peerstore().(wps.WakuPeerstore).Origin(p.AddrInfo.ID) _, err := pm.host.Peerstore().(wps.WakuPeerstore).Origin(p.AddrInfo.ID)
if err == nil { if err == nil {
pm.logger.Debug("peer already in peerStore", logging.HostID("peer", p.AddrInfo.ID)) enr, err := pm.host.Peerstore().(wps.WakuPeerstore).ENR(p.AddrInfo.ID)
return // Verifying if the enr record is more recent (DiscV5 and peer exchange can return peers already seen)
if err == nil && enr.Record().Seq() > p.ENR.Seq() {
pm.logger.Debug("found discovered peer already in peerStore", logging.HostID("peer", p.AddrInfo.ID))
return
}
} }
supportedProtos := []protocol.ID{} supportedProtos := []protocol.ID{}
if len(p.PubsubTopics) == 0 && p.ENR != nil { if len(p.PubsubTopics) == 0 && p.ENR != nil {
// Try to fetch shard info and supported protocols from ENR to arrive at pubSub topics. // Try to fetch shard info and supported protocols from ENR to arrive at pubSub topics.