chore: address review comments

This commit is contained in:
Prem Chaitanya Prathi 2023-08-08 10:16:54 +05:30
parent b1a4d739ce
commit 65f26978f9
No known key found for this signature in database
2 changed files with 7 additions and 5 deletions

View File

@ -26,7 +26,7 @@ pipeline {
PATH = "${env.PATH}:${env.GOPATH}/bin" PATH = "${env.PATH}:${env.GOPATH}/bin"
/* Necesary to avoid cache poisoning by other builds. */ /* Necesary to avoid cache poisoning by other builds. */
GOLANGCI_LINT_CACHE = "${env.WORKSPACE_TMP}/golangci-lint" GOLANGCI_LINT_CACHE = "${env.WORKSPACE_TMP}/golangci-lint"
/* Ganache config */ /* Ganache config */
GANACHE_RPC_PORT = "${8989 + env.EXECUTOR_NUMBER.toInteger()}" GANACHE_RPC_PORT = "${8989 + env.EXECUTOR_NUMBER.toInteger()}"
GANACHE_MNEMONIC = 'swim relax risk shy chimney please usual search industry board music segment' GANACHE_MNEMONIC = 'swim relax risk shy chimney please usual search industry board music segment'
} }

View File

@ -26,19 +26,21 @@ pipeline {
PATH = "${env.PATH}:${env.GOPATH}/bin" PATH = "${env.PATH}:${env.GOPATH}/bin"
/* Necesary to avoid cache poisoning by other builds. */ /* Necesary to avoid cache poisoning by other builds. */
GOLANGCI_LINT_CACHE = "${env.WORKSPACE_TMP}/golangci-lint" GOLANGCI_LINT_CACHE = "${env.WORKSPACE_TMP}/golangci-lint"
/* Ganache config */ /* Ganache config */
GANACHE_RPC_PORT = "${8989 + env.EXECUTOR_NUMBER.toInteger()}" GANACHE_RPC_PORT = "${8989 + env.EXECUTOR_NUMBER.toInteger()}"
GANACHE_MNEMONIC = 'swim relax risk shy chimney please usual search industry board music segment'
} }
stages { stages {
stage('Test') { stage('Tests with race flag') {
steps { script { dir(env.REPO) { steps { script { dir(env.REPO) {
nix.develop('make test-with-race', pure: false) nix.develop('make test-with-race', pure: false)
} } } } } }
} }
stage('Ganache') { stage('Ganache') {
environment {
GANACHE_MNEMONIC = 'swim relax risk shy chimney please usual search industry board music segment'
}
steps { script { steps { script {
ganache = docker.image( ganache = docker.image(
'trufflesuite/ganache:v7.4.1' 'trufflesuite/ganache:v7.4.1'
@ -49,7 +51,7 @@ pipeline {
} } } }
} }
stage('On-chain tests') { stage('On-chain tests with race flag') {
environment { environment {
GANACHE_NETWORK_RPC_URL = "ws://localhost:${env.GANACHE_RPC_PORT}" GANACHE_NETWORK_RPC_URL = "ws://localhost:${env.GANACHE_RPC_PORT}"
} }