status-im
/
go-waku
mirror of https://github.com/status-im/go-waku.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: goroutine leak on ping

This commit is contained in:
Richard Ramos 2021-10-16 19:09:04 -04:00
parent 5744879242
commit 5f3df9343c
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
waku/v2/node/wakunode2.go
View File

@ -695,13 +695,26 @@ func (w *WakuNode) startKeepAlive(t time.Duration) {
w.ping = ping.NewPingService(w.host)
ticker := time.NewTicker(t)
go func() {
for {
select {
case <-ticker.C:
for _, peer := range w.host.Network().Peers() {
log.Debug("Pinging", peer)
w.ping.Ping(w.ctx, peer)
for _, p := range w.host.Network().Peers() {
log.Debug("Pinging ", p)
go func(peer peer.ID) {
ctx, cancel := context.WithTimeout(w.ctx, 3*time.Second)
defer cancel()
pr := w.ping.Ping(ctx, peer)
select {
case res := <-pr:
if res.Error != nil {
log.Error(fmt.Sprintf("Could not ping %s: %s", peer, res.Error.Error()))
}
case <-ctx.Done():
log.Error(fmt.Sprintf("Could not ping %s: %s", peer, ctx.Err()))
}
}(p)
}
case <-w.quit:
ticker.Stop()