status-im/go-libp2p-pubsub
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix race condition in rpc fragmentation test

Browse Source
This commit is contained in:
Yusef Napora 2020-05-05 14:13:26 -04:00 committed by vyzo
parent 8642662340
commit cb65238a39
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gossipsub_test.go
View File

@ -1752,6 +1752,8 @@ func TestGossipsubRPCFragmentation(t *testing.T) {
// wait a bit for them to be received via gossip by the fake peer // wait a bit for them to be received via gossip by the fake peer
time.Sleep(5 * time.Second) time.Sleep(5 * time.Second)
iwe.lk.Lock()
defer iwe.lk.Unlock()
// we should have received all the messages // we should have received all the messages
if iwe.msgsReceived != nMessages { if iwe.msgsReceived != nMessages {
@ -1778,6 +1780,7 @@ func TestGossipsubRPCFragmentation(t *testing.T) {
// test that large responses to IWANT requests are fragmented into multiple RPCs. // test that large responses to IWANT requests are fragmented into multiple RPCs.
type iwantEverything struct { type iwantEverything struct {
h host.Host h host.Host
lk sync.Mutex
rpcsWithMessages int rpcsWithMessages int
msgsReceived int msgsReceived int
ihavesReceived int ihavesReceived int
@ -1816,6 +1819,7 @@ func (iwe *iwantEverything) handleStream(s network.Stream) {
return return
} }
iwe.lk.Lock()
if len(rpc.Publish) != 0 { if len(rpc.Publish) != 0 {
iwe.rpcsWithMessages++ iwe.rpcsWithMessages++
} }
@ -1852,5 +1856,6 @@ func (iwe *iwantEverything) handleStream(s network.Stream) {
panic(err) panic(err)
} }
} }
iwe.lk.Unlock()
} }
} }