From f92d04a4ba7db63c9dc518f7f40f0d1b382678d9 Mon Sep 17 00:00:00 2001 From: Danny van Kooten Date: Wed, 10 Oct 2018 16:38:29 +0200 Subject: [PATCH] default value for pageview.IsBounce should be true, not false. --- pkg/api/collect.go | 2 ++ pkg/datastore/sqlstore/pageviews.go | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/api/collect.go b/pkg/api/collect.go index 333371a..d02c551 100644 --- a/pkg/api/collect.go +++ b/pkg/api/collect.go @@ -61,6 +61,8 @@ func (c *Collector) ServeHTTP(w http.ResponseWriter, r *http.Request) { IsUnique: q.Get("u") == "1", Referrer: parseReferrer(q.Get("r")), IsFinished: false, + IsBounce: true, + Duration: 0, Timestamp: now, } diff --git a/pkg/datastore/sqlstore/pageviews.go b/pkg/datastore/sqlstore/pageviews.go index 692853e..a02a8eb 100644 --- a/pkg/datastore/sqlstore/pageviews.go +++ b/pkg/datastore/sqlstore/pageviews.go @@ -30,7 +30,7 @@ func (db *sqlstore) InsertPageviews(pageviews []*models.Pageview) error { } // generate placeholders string - placeholderTemplate := "(?, ?, ?, ?, ?, ?, ?, ?, ?, FALSE, FALSE, 0)," + placeholderTemplate := "(?, ?, ?, ?, ?, ?, ?, ?, ?, TRUE, FALSE, 0)," placeholders := strings.Repeat(placeholderTemplate, n) placeholders = placeholders[:len(placeholders)-1] nPlaceholders := strings.Count(placeholderTemplate, "?") @@ -44,7 +44,7 @@ func (db *sqlstore) InsertPageviews(pageviews []*models.Pageview) error { for i := range pageviews { // test for columns with ignored values - if pageviews[i].IsBounce != false || pageviews[i].Duration > 0 || pageviews[i].IsFinished != false { + if pageviews[i].IsBounce != true || pageviews[i].Duration > 0 || pageviews[i].IsFinished != false { log.Warnf("inserting pageview with invalid column values for bulk-insert") }