status-im
/
fathom
mirror of https://github.com/status-im/fathom.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

re-use img.onload and use timeout as failsafe to always remove img from DOM. #148

This commit is contained in:
Danny van Kooten 2018-10-10 10:57:45 +02:00
parent 470db5189d
commit 39a7fd249d
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
assets/src/js/tracker.js
View File

@ -156,9 +156,9 @@ function trackPageview() {
}; };
let url = config.trackerUrl || findTrackerUrl() let url = config.trackerUrl || findTrackerUrl()
let i = document.createElement('img'); let img = document.createElement('img');
i.src = url + stringifyObject(d); img.src = url + stringifyObject(d);
i.addEventListener('load', function() { img.addEventListener('load', function() {
let now = new Date(); let now = new Date();
let midnight = new Date(now.getFullYear(), now.getMonth(), now.getDate(), 24, 0, 0); let midnight = new Date(now.getFullYear(), now.getMonth(), now.getDate(), 24, 0, 0);
@ -171,9 +171,23 @@ function trackPageview() {
data.isNewSession = false; data.isNewSession = false;
data.lastSeen = +new Date(); data.lastSeen = +new Date();
setCookie('_fathom', JSON.stringify(data), { expires: midnight, path: '/' }); setCookie('_fathom', JSON.stringify(data), { expires: midnight, path: '/' });
// remove tracking img from DOM
document.body.removeChild(img)
}); });
i.addEventListener('load', () => document.body.removeChild(i));
document.body.appendChild(i); // in case img.onload never fires, remove img after 1s & reset src attribute to cancel request
window.setTimeout(() => {
if(!img.parentNode) {
return;
}
img.src = '';
document.body.removeChild(img)
}, 1000);
// add to DOM to fire request
document.body.appendChild(img);
} }
// override global fathom object // override global fathom object