From cea8d3a5b584e609dc406b351a5b290ddba099ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Bylica?= <chfast@gmail.com>
Date: Tue, 14 May 2019 12:03:29 +0200
Subject: [PATCH] cpp: Fix evmc::result's move assignment operator

---
 include/evmc/evmc.hpp | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/include/evmc/evmc.hpp b/include/evmc/evmc.hpp
index 1ae2d12..b829a15 100644
--- a/include/evmc/evmc.hpp
+++ b/include/evmc/evmc.hpp
@@ -39,16 +39,22 @@ public:
     /// Move constructor.
     result(result&& other) noexcept : evmc_result{other}
     {
-        // Disable releaser of the rvalue object.
-        other.release = nullptr;
+        other.release = nullptr;  // Disable releasing of the rvalue object.
     }
 
     result(result const&) = delete;
 
-    /// Move-and-swap assignment operator.
-    result& operator=(result other) noexcept
+    /// Move assignment operator.
+    ///
+    /// The self-assigment MUST never happen.
+    ///
+    /// @param other The other result object.
+    /// @return      The reference to the left-hand side object.
+    result& operator=(result&& other) noexcept
     {
-        std::swap(*this, other);
+        this->~result();                           // Release this object.
+        static_cast<evmc_result&>(*this) = other;  // Copy data.
+        other.release = nullptr;                   // Disable releasing of the rvalue object.
         return *this;
     }