status-im/ethers.js
2
0
Fork 0
mirror of synced 2025-02-24 20:18:07 +00:00
Code Issues Projects Releases Wiki Activity

Some nodes (e.g. TestRPC) do not like checksum addresses in their RPC calls.

Browse Source
This commit is contained in:
Richard Moore 2018-01-17 17:26:31 -05:00
parent 34fd2882d8
commit 5fc59dd1cf
No known key found for this signature in database
GPG Key ID: 525F70A6FCABC295
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
providers/web3-provider.js
View File

@ -55,7 +55,7 @@ utils.defineProperty(Web3Signer.prototype, 'sendTransaction', function(transacti
var provider = this.provider; var provider = this.provider;
transaction = JsonRpcProvider._hexlifyTransaction(transaction); transaction = JsonRpcProvider._hexlifyTransaction(transaction);
return this.getAddress().then(function(address) { return this.getAddress().then(function(address) {
transaction.from = address; transaction.from = address.toLowerCase();
return provider.send('eth_sendTransaction', [ transaction ]).then(function(hash) { return provider.send('eth_sendTransaction', [ transaction ]).then(function(hash) {
return new Promise(function(resolve, reject) { return new Promise(function(resolve, reject) {
function check() { function check() {
@ -81,13 +81,13 @@ utils.defineProperty(Web3Signer.prototype, 'signMessage', function(message) {
// https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign // https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign
var method = 'eth_sign'; var method = 'eth_sign';
var params = [ address, utils.hexlify(data) ]; var params = [ address.toLowerCase(), utils.hexlify(data) ];
// Metamask complains about eth_sign (and on some versions hangs) // Metamask complains about eth_sign (and on some versions hangs)
if (provider._web3Provider.isMetaMask) { if (provider._web3Provider.isMetaMask) {
// https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign // https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign
method = 'personal_sign'; method = 'personal_sign';
params = [ utils.hexlify(data), address ]; params = [ utils.hexlify(data), address.toLowerCase() ];
} }
return provider.send(method, params); return provider.send(method, params);
@ -98,7 +98,7 @@ utils.defineProperty(Web3Signer.prototype, 'unlock', function(password) {
var provider = this.provider; var provider = this.provider;
return this.getAddress().then(function(address) { return this.getAddress().then(function(address) {
return provider.send('personal_unlockAccount', [ address, password, null ]); return provider.send('personal_unlockAccount', [ address.toLowerCase(), password, null ]);
}); });
}); });