diff --git a/ethereumj-core/src/main/java/org/ethereum/core/Block.java b/ethereumj-core/src/main/java/org/ethereum/core/Block.java index 1fd927b7..f9fbdf78 100644 --- a/ethereumj-core/src/main/java/org/ethereum/core/Block.java +++ b/ethereumj-core/src/main/java/org/ethereum/core/Block.java @@ -23,7 +23,7 @@ import java.util.concurrent.CopyOnWriteArrayList; * (such blocks are known as uncles). * * www.ethereumJ.com - * @authors: Roman Mandeleil, + * @author Roman Mandeleil, * Nick Savers * Created on: 20/05/2014 10:44 */ diff --git a/ethereumj-core/src/main/java/org/ethereum/core/BlockHeader.java b/ethereumj-core/src/main/java/org/ethereum/core/BlockHeader.java index b80fe8c3..c26963b7 100644 --- a/ethereumj-core/src/main/java/org/ethereum/core/BlockHeader.java +++ b/ethereumj-core/src/main/java/org/ethereum/core/BlockHeader.java @@ -154,7 +154,7 @@ public class BlockHeader { /** * Verify that block is valid for its difficulty * - * @return + * @return boolean */ public boolean validateNonce() { BigInteger max = BigInteger.valueOf(2).pow(256); diff --git a/ethereumj-core/src/main/java/org/ethereum/core/BlockchainImpl.java b/ethereumj-core/src/main/java/org/ethereum/core/BlockchainImpl.java index fad124a2..15447144 100644 --- a/ethereumj-core/src/main/java/org/ethereum/core/BlockchainImpl.java +++ b/ethereumj-core/src/main/java/org/ethereum/core/BlockchainImpl.java @@ -43,7 +43,7 @@ import static org.ethereum.core.Denomination.SZABO; * See Ethereum Whitepaper * * www.ethereumJ.com - * @authors: Roman Mandeleil, + * @author Roman Mandeleil, * Nick Savers * Created on: 20/05/2014 10:44 */ diff --git a/ethereumj-core/src/main/java/org/ethereum/core/Transaction.java b/ethereumj-core/src/main/java/org/ethereum/core/Transaction.java index 7eb89c73..24d9a378 100644 --- a/ethereumj-core/src/main/java/org/ethereum/core/Transaction.java +++ b/ethereumj-core/src/main/java/org/ethereum/core/Transaction.java @@ -171,7 +171,7 @@ public class Transaction { return this.receiveAddress == null || this.receiveAddress == ByteUtil.EMPTY_BYTE_ARRAY; } - /********* + /* * Crypto */ diff --git a/ethereumj-core/src/main/java/org/ethereum/crypto/ECKey.java b/ethereumj-core/src/main/java/org/ethereum/crypto/ECKey.java index 98f87e56..8122b5a9 100644 --- a/ethereumj-core/src/main/java/org/ethereum/crypto/ECKey.java +++ b/ethereumj-core/src/main/java/org/ethereum/crypto/ECKey.java @@ -65,7 +65,7 @@ import org.spongycastle.util.encoders.Hex; * this class so round-tripping preserves state. Unless you're working with old software or doing unusual things, you * can usually ignore the compressed/uncompressed distinction.

* - * This code is borrowed from the bitcoinj project and altered to fit Ethereum.
+ * This code is borrowed from the bitcoinj project and altered to fit Ethereum.
* See bitcoinj on GitHub */ public class ECKey implements Serializable { @@ -375,7 +375,7 @@ public class ECKey implements Serializable { * Signs the given hash and returns the R and S components as BigIntegers * and put them in ECDSASignature * - * @param rlpData to sign + * @param input to sign * @return ECDSASignature signature that contains the R and S components */ public ECDSASignature doSign(byte[] input) { @@ -419,7 +419,7 @@ public class ECKey implements Serializable { * containing the public key that was used to sign it. This can then be compared to the expected public key to * determine if the signature was correct. * - * @param message a piece of human readable text that was signed + * @param messageHash a piece of human readable text that was signed * @param signatureBase64 The Ethereum-format message signature in base64 * @throws SignatureException If the public key could not be recovered or if there was a signature format error. */ diff --git a/ethereumj-core/src/main/java/org/ethereum/crypto/HashUtil.java b/ethereumj-core/src/main/java/org/ethereum/crypto/HashUtil.java index 0a66c916..1eff7321 100644 --- a/ethereumj-core/src/main/java/org/ethereum/crypto/HashUtil.java +++ b/ethereumj-core/src/main/java/org/ethereum/crypto/HashUtil.java @@ -67,7 +67,7 @@ public class HashUtil { } /** - * See {@link ByteUtil#doubleDigest(byte[], int, int)}. + * @see #doubleDigest(byte[], int, int) */ public static byte[] doubleDigest(byte[] input) { return doubleDigest(input, 0, input.length); diff --git a/ethereumj-core/src/main/java/org/ethereum/db/RepositoryImpl.java b/ethereumj-core/src/main/java/org/ethereum/db/RepositoryImpl.java index d96c9a9c..7a4af4ae 100644 --- a/ethereumj-core/src/main/java/org/ethereum/db/RepositoryImpl.java +++ b/ethereumj-core/src/main/java/org/ethereum/db/RepositoryImpl.java @@ -36,17 +36,17 @@ import static org.ethereum.config.SystemProperties.CONFIG; /** * *********************************************************************************** - Repository - | - --> AccountState ---> Trie ---> leveldb (state) /key=address - --> nonce - --> balance - --> stateRoot - --> codeHash - | - --> ContractDetails ---> leveldb(details) /key=address - --> code ---> sha3(code) // saved into AccountInfo.codeHash - --> storage ---> Trie // to calculate the AccountInfo.stateRoot + Repository
+ |
+ --> AccountState ---> Trie ---> leveldb (state) /key=address
+ --> nonce
+ --> balance
+ --> stateRoot
+ --> codeHash
+ |
+ --> ContractDetails ---> leveldb(details) /key=address
+ --> code ---> sha3(code) // saved into AccountInfo.codeHash
+ --> storage ---> Trie // to calculate the AccountInfo.stateRoot
*********************************************************************************** * * www.ethereumJ.com @@ -73,7 +73,7 @@ public class RepositoryImpl implements Repository { * Create a new Repository DAO * assuming empty db and thus no stateRoot * - * @See loadBlockchain() to update the stateRoot + * @see #loadBlockchain() to update the stateRoot */ public RepositoryImpl() { this("blockchain", "details", "state"); @@ -147,7 +147,6 @@ public class RepositoryImpl implements Repository { listener.onPreloadedBlock(Genesis.getInstance()); } - logger.debug("Block #{} -> {}", Genesis.NUMBER, blockchain.getLastBlock().toFlatString()); dumpState(Genesis.getInstance(), 0, 0, null); } else { logger.debug("Displaying blocks stored in DB sorted on blocknumber"); diff --git a/ethereumj-core/src/main/java/org/ethereum/facade/Repository.java b/ethereumj-core/src/main/java/org/ethereum/facade/Repository.java index 758239dc..71feff2d 100644 --- a/ethereumj-core/src/main/java/org/ethereum/facade/Repository.java +++ b/ethereumj-core/src/main/java/org/ethereum/facade/Repository.java @@ -21,7 +21,7 @@ public interface Repository { /** * Create a new account in the database * - * @param address of the contract + * @param addr of the contract * @return newly created account state */ public AccountState createAccount(byte[] addr); @@ -29,7 +29,7 @@ public interface Repository { /** * Retrieve an account * - * @param address of the account + * @param addr of the account * @return account state as stored in the database */ public AccountState getAccountState(byte[] addr); @@ -37,7 +37,7 @@ public interface Repository { /** * Deletes the account * - * @param address of the account + * @param addr of the account */ public void delete(byte[] addr); @@ -52,7 +52,7 @@ public interface Repository { /** * Get current nonce of a given account * - * @param addres of the account + * @param addr of the account * @return value of the nonce */ public BigInteger getNonce(byte[] addr); @@ -60,7 +60,7 @@ public interface Repository { /** * Retrieve contract details for a given account from the database * - * @param address of the account + * @param addr of the account * @return new contract details */ public ContractDetails getContractDetails(byte[] addr); @@ -68,7 +68,7 @@ public interface Repository { /** * Store code associated with an account * - * @param address for the account + * @param addr for the account * @param code that will be associated with this account */ public void saveCode(byte[] addr, byte[] code); @@ -76,7 +76,7 @@ public interface Repository { /** * Retrieve the code associated with an account * - * @param address of the account + * @param addr of the account * @return code in byte-array format */ public byte[] getCode(byte[] addr); @@ -84,7 +84,7 @@ public interface Repository { /** * Put a value in storage of an account at a given key * - * @param address of the account + * @param addr of the account * @param key of the data to store * @param value is the data to store */ @@ -93,7 +93,7 @@ public interface Repository { /** * Retrieve storage value from an account for a given key * - * @param address of the account + * @param addr of the account * @param key associated with this value * @return data in the form of a DataWord */ @@ -117,7 +117,7 @@ public interface Repository { /** * Retrieve balance of an account * - * @param address of the account + * @param addr of the account * @return balance of the account as a BigInteger value */ public BigInteger getBalance(byte[] addr); @@ -125,7 +125,7 @@ public interface Repository { /** * Add value to the balance of an account * - * @param address of the account + * @param addr of the account * @param value to be added * @return new balance of the account */ diff --git a/ethereumj-core/src/main/java/org/ethereum/net/eth/BlockHashesMessage.java b/ethereumj-core/src/main/java/org/ethereum/net/eth/BlockHashesMessage.java index a817272b..e74f75f3 100644 --- a/ethereumj-core/src/main/java/org/ethereum/net/eth/BlockHashesMessage.java +++ b/ethereumj-core/src/main/java/org/ethereum/net/eth/BlockHashesMessage.java @@ -14,7 +14,7 @@ import org.ethereum.util.Utils; /** * Wrapper around an Ethereum BlockHashes message on the network * - * @see {@link org.ethereum.net.eth.EthMessageCodes#BLOCK_HASHES} + * @see org.ethereum.net.eth.EthMessageCodes#BLOCK_HASHES */ public class BlockHashesMessage extends EthMessage { diff --git a/ethereumj-core/src/main/java/org/ethereum/net/eth/BlocksMessage.java b/ethereumj-core/src/main/java/org/ethereum/net/eth/BlocksMessage.java index 56126730..59d88c70 100644 --- a/ethereumj-core/src/main/java/org/ethereum/net/eth/BlocksMessage.java +++ b/ethereumj-core/src/main/java/org/ethereum/net/eth/BlocksMessage.java @@ -11,7 +11,7 @@ import org.ethereum.util.RLPList; /** * Wrapper around an Ethereum Blocks message on the network * - * @see {@link org.ethereum.net.eth.EthMessageCodes#BLOCKS} + * @see org.ethereum.net.eth.EthMessageCodes#BLOCKS */ public class BlocksMessage extends EthMessage { diff --git a/ethereumj-core/src/main/java/org/ethereum/net/eth/EthHandler.java b/ethereumj-core/src/main/java/org/ethereum/net/eth/EthHandler.java index c7f39934..63380636 100644 --- a/ethereumj-core/src/main/java/org/ethereum/net/eth/EthHandler.java +++ b/ethereumj-core/src/main/java/org/ethereum/net/eth/EthHandler.java @@ -24,7 +24,7 @@ import static org.ethereum.net.message.StaticMessages.GET_TRANSACTIONS_MESSAGE; /** * Process the messages between peers with 'eth' capability on the network. - *

+ *

* Peers with 'eth' capability can send/receive: *