minor fix for last commit

This commit is contained in:
romanman 2014-07-10 14:39:48 +03:00
parent 7c129164c3
commit 1dd17488ac
4 changed files with 12 additions and 4 deletions

View File

@ -3,19 +3,19 @@
##### TODO list: ##### TODO list:
---------------- ----------------
- [X] **State management** trie for storage hash calculation - [x] **State management** trie for storage hash calculation
and update hash into AccountState and update hash into AccountState
- [ ] **GUI screen** a screen that will hold table with full state representation - [ ] **GUI screen** a screen that will hold table with full state representation
- [ ] **SerpentCompiler** compile create(gas, mem_start, import("examples/mul2.se")) - [ ] **SerpentCompiler** compile create(gas, mem_start, import("examples/mul2.se"))
https://github.com/ethereum/wiki/wiki/Serpent https://github.com/ethereum/wiki/wiki/Serpent
- [ ] **SerpentCompiler** compile return(array) correct - [ ] **SerpentCompiler** compile return(array) correct
- [ ] **VM execution:** SUICIDE op adjust - [x] **VM execution:** SUICIDE op adjust
- [ ] **ProgramPlayDialog** support internal calls - [ ] **ProgramPlayDialog** support internal calls
- [ ] **Build:** extract core module and studio application - [ ] **Build:** extract core module and studio application
- [ ] **Performance:** BigInteger math change for constant arrays implementation - [ ] **Performance:** BigInteger math change for constant arrays implementation
economy for memory allocation economy for memory allocation
- [ ] **Command Line:** add the headless run option - [ ] **Command Line:** add the headless run option
- [ ] **Testing by JSON files:** follow cpp client performs test case by getting json file contains the test describe - [x] **Testing by JSON files:** follow cpp client performs test case by getting json file contains the test describe
- [ ] **SerpentCompiler** Serpent new syntax: - [ ] **SerpentCompiler** Serpent new syntax:
(@> @< @/ @%) - unsigned operations (@> @< @/ @%) - unsigned operations
> < / % - default are all signed operations > < / % - default are all signed operations

View File

@ -232,12 +232,13 @@ public class Repository {
public void saveCode(byte[] address, byte[] code) { public void saveCode(byte[] address, byte[] code) {
if (code == null) return;
if (logger.isDebugEnabled()) if (logger.isDebugEnabled())
logger.debug("saveCode: \n address: [ {} ], \n code: [ {} ]", logger.debug("saveCode: \n address: [ {} ], \n code: [ {} ]",
Hex.toHexString(address), Hex.toHexString(address),
Hex.toHexString(code)); Hex.toHexString(code));
if (code == null) return;
AccountState state = getAccountState(address); AccountState state = getAccountState(address);
if (state == null) return; if (state == null) return;

View File

@ -190,6 +190,11 @@ public class TestRunner {
} }
} }
// TODO: assert that you have no extra accounts in the repository
// TODO: -> basically the deleted by suicide should be deleted
// TODO: -> and no unexpected created
List<org.ethereum.vm.CallCreate> resultCallCreates = List<org.ethereum.vm.CallCreate> resultCallCreates =
program.getResult().getCallCreateList(); program.getResult().getCallCreateList();

View File

@ -74,6 +74,8 @@ public class ProgramResult {
public void addDeleteAccounts(List<DataWord> accounts){ public void addDeleteAccounts(List<DataWord> accounts){
if (accounts == null) return;
if (deleteAccounts == null){ if (deleteAccounts == null){
deleteAccounts = new ArrayList<>(); deleteAccounts = new ArrayList<>();
} }