Commit Graph

102 Commits

Author SHA1 Message Date
Csaba Kiraly 8d332788b9
clarify the use of LossyDAS
Clarify that what matters is the false positive threshold, allowing
different sampling strategies as protocol compliant behavior.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
Csaba Kiraly b848ca6dc7
improved sampling description
- describe sample selection
- describe sample queries

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
George Kadianakis fdeff744ff
EIP-7594: Add a missing check and a missing test vector (#3765) 2024-05-14 17:18:14 +03:00
Nishant Das 8f73a47423
Update p2p-interface.md 2024-05-09 16:14:52 +08:00
Nishant Das b9befda08b
Update p2p-interface.md 2024-05-09 16:03:55 +08:00
Hsiao-Wei Wang 313a64e9c1
Merge pull request #3748 from ethereum/fix-get_custody_columns
Fix `get_custody_columns`
2024-05-07 22:43:46 +08:00
Hsiao-Wei Wang 9ffd08a9dc
The return values MUST be sent in `(slot, column_index)` order. 2024-05-07 20:28:34 +08:00
Hsiao-Wei Wang fdad206f3c
Apply @dankrad's suggestion 2024-05-07 20:26:56 +08:00
Hsiao-Wei Wang 950136c50d
Apply suggestions from code review
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2024-05-07 18:30:28 +08:00
Hsiao-Wei Wang 34756a81c6
Add `DataColumnSidecarsByRange` v1 Req/Resp 2024-05-06 19:11:23 +08:00
Hsiao-Wei Wang 9c1acbb5e5
Fix `get_custody_columns` 2024-05-06 17:25:47 +08:00
George Kadianakis 1ef75e0875 Be consistent between ids and indices 2024-05-03 19:00:51 +03:00
Kevaundray Wedderburn 5699eedd4d pad column_indices 2024-05-03 16:43:11 +01:00
kevaundray e7b49dc670
chore: Add type casts reducing the diff for #3697 (#3734) 2024-04-29 08:14:55 -05:00
Hsiao-Wei Wang a4e04ebf64
Misc fix 2024-04-27 12:11:29 +08:00
Justin Traglia b4188829b3 Rename compute_cells_and_proofs to compute_cells_and_kzg_proofs 2024-04-25 21:57:22 -05:00
Justin Traglia 4f66521208 Fix parameter indentations 2024-04-25 17:34:10 -05:00
Justin Traglia ac1ce3b3f0 Rename verify_cell_proof to verify_cell_kzg_proof 2024-04-25 17:31:22 -05:00
Hsiao-Wei Wang e1d71216bb
Merge pull request #3715 from ethereum/das-test-vectors
Make `get_custody_columns` return sorted values and add `get_custody_columns` tests
2024-04-25 03:01:51 +08:00
Hsiao-Wei Wang 24899b7fba
Apply suggestions from @jtraglia 2024-04-24 19:04:40 +08:00
Alex Stokes b13e03e671
Merge pull request #3714 from kevaundray/kw/use-optimized-bls-msm
chore: use py-arkworks's multi-exp method inside of `g1_lincomb` and `g2_lincomb`
2024-04-23 11:57:13 -06:00
Kevaundray Wedderburn f3302a3836 - return serialized identity points
- result = None initially
2024-04-23 15:11:46 +01:00
Kevaundray Wedderburn d28a0164d2 add is_zero check 2024-04-23 14:55:37 +01:00
Kevaundray Wedderburn 5eb19b3cef modify g1_lincomb and g2_lincomb 2024-04-23 14:21:54 +01:00
Kevaundray Wedderburn 5a74f40442 g2_lincomb uses g2_multi_exp 2024-04-23 13:38:27 +01:00
Hsiao-Wei Wang 57c14e5400
Add `get_custody_columns` tests 2024-04-23 20:21:33 +08:00
Justin Traglia 73637c84b2
EIP-7594: Add asserts for public functions (#3684)
* Add length asserts for public PeerDAS functions

* Fix cell asserts

* Rename field variable to satisfy linter

* Add asserts for row/column indices

* Use CELLS_PER_EXT_BLOB

* Update to work with new spec changes

* Fix indentation

* Add explict check for cell_id
2024-04-23 12:12:26 +03:00
kevaundray e51f7df77d
chore: make list copy explicit in `divide_polynomialcoeff` (#3706) 2024-04-22 10:43:04 -05:00
George Kadianakis 4fceca2b75
Merge pull request #3710 from kevaundray/kw/rm-field-elements-from-das-core
chore: use CELLS_PER_EXT_BLOB to compute the number of columns
2024-04-22 17:59:31 +03:00
Justin Traglia bcd0a09e68
Integrate new Coset/CosetEvals types (#3701)
* Add CellBytes type

* Use ByteVector, not Vector

* Fix tests

* Replace b"" with []

* Apply suggestions for bytes_to_cell

* Add/integrate new CosetEvals type

* Remove accidental new line

* Fix recover_all_cells

* Fix recover_matrix

* fix CosetEvals abstraction leak

* Introduce internal Coset type for `coset_for_cell()`

* Use CosetEvals in compute_kzg_proof_multi_impl()

* update test

* satisfy linter

* Fix two nits I noticed

---------

Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Co-authored-by: George Kadianakis <desnacked@riseup.net>
2024-04-22 17:03:57 +03:00
Kevaundray Wedderburn 79d255b15a use CELLS_PER_EXT_BLOB in das-core 2024-04-22 14:08:44 +01:00
kevaundray 5c561722b8
add BLS_MODULUS to places where we subtract two integers (#3709) 2024-04-22 15:57:52 +03:00
George Kadianakis 858f51617d
Merge pull request #3708 from kevaundray/kw/hww-max-extended-matrix-size
chore: add a new config `MAX_EXTENDED_MATRIX_SIZE`
2024-04-22 15:56:51 +03:00
Kevaundray Wedderburn 3f2d498cee rename 2024-04-22 13:02:42 +01:00
George Kadianakis 0ffd0ca432
Merge pull request #3703 from kevaundray/kw/add-comment-for-verify-kzg
chore: Add more docs for the kzg verify algorithm
2024-04-22 12:46:12 +03:00
Hsiao-Wei Wang e46c4c39fb workaround: add a new config `MAX_EXTENDED_MATRIX_SIZE` to avoid `class Container(List[c, a*b])` 2024-04-22 10:31:58 +01:00
Kevaundray Wedderburn dca048d8df push @asn-d6 suggestions 2024-04-22 09:57:58 +01:00
kevaundray 0e4fc984ef
Remove unused return value (#3704) 2024-04-19 20:16:19 -05:00
Kevaundray Wedderburn 4684c5748c add comment for verify algorithm 2024-04-19 19:19:17 +01:00
Justin Traglia bc69c357b4
Merge pull request #3702 from kevaundray/kw/fix_recover_polynomial
Change `recover_polynomial` to `recover_all_cells`
2024-04-19 12:54:21 -05:00
Kevaundray Wedderburn 3ddd00e741 use recover_all_cells 2024-04-19 12:50:32 +01:00
Kevaundray Wedderburn 32cbda9de2 rename to recover_all_cells 2024-04-19 12:50:22 +01:00
Kevaundray Wedderburn 33dfa88160 fix bad merge 2024-04-19 12:07:58 +01:00
Kevaundray Wedderburn c2b7c0b414 Merge branch 'dev' into kw/optimize-compute-kzg-proof-multi 2024-04-19 12:04:15 +01:00
Hsiao-Wei Wang 9c04cf13c9
Merge pull request #3695 from kevaundray/kw/fix-kzg-multi-comment
chore: Fixes and elaborates on comments for `compute_kzg_proof_multi`
2024-04-19 15:32:09 +09:00
Hsiao-Wei Wang 0b312cae8b
Merge pull request #3692 from kevaundray/patch-11
chore: Change g2_lincomb to take in G2Points
2024-04-19 15:30:22 +09:00
kevaundray 8e3500b2b5
Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-04-18 20:26:52 +01:00
kevaundray 1669723adf
Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-04-18 20:26:46 +01:00
Kevaundray Wedderburn 6c8955d4bc chore: fix comment 2024-04-18 18:12:15 +01:00
Kevaundray Wedderburn 912038bb08 modify cell proofs comment 2024-04-18 18:11:41 +01:00