Commit Graph

7699 Commits

Author SHA1 Message Date
Justin Traglia 02090d94ab Remove pytest import 2022-05-10 11:00:16 -05:00
Justin Traglia d1f0187076 Revert "Move test case to new location"
This reverts commit e2cbdb2b67.
2022-05-10 10:48:59 -05:00
Justin Traglia 5868a53cf1 Revert "Fix linter warnings again"
This reverts commit ac7267c938.
2022-05-10 10:48:51 -05:00
Hsiao-Wei Wang 8abf2393d0
Merge pull request #2890 from ethereum/format
minor patch to bytes formatting in capella
2022-05-10 17:47:39 +02:00
Danny Ryan c0a8178fff
minor patch to bytes formatting in capella 2022-05-10 09:37:01 -06:00
Danny Ryan 242f286f6e
Merge pull request #2878 from michaelsproul/forkchoice-b4-propose
Require fork choice to run before proposal
2022-05-10 09:23:16 -06:00
Hsiao-Wei Wang 96de0fe646
Merge pull request #2889 from jtraglia/remove-set-sampling
Convert sets to sorted lists prior to sampling
2022-05-10 16:12:28 +02:00
Justin Traglia ac7267c938 Fix linter warnings again 2022-05-09 16:50:43 -05:00
Justin Traglia e2cbdb2b67 Move test case to new location 2022-05-09 16:47:19 -05:00
Justin Traglia 90c1825637 Convert participation_fn from lambda to def
I felt that the the lambda was a little too complicated.
2022-05-09 15:53:36 -05:00
Justin Traglia 9dcb2eecbc Fix linter warnings 2022-05-09 14:28:54 -05:00
Justin Traglia a7bda480fe Convert sets to sorted lists prior to sampling
This is because sampling of sets has been deprecated in Python 3.9. I used
sorted() instead of list() so that things are deterministic.
2022-05-09 14:09:27 -05:00
Caspar Schwarz-Schilling 712a4f9cf1 Fix linting 2022-05-09 15:05:05 +02:00
Caspar Schwarz-Schilling f5303ca58e Update PROPOSER_SCORE_BOOST to 33 percent 2022-05-09 10:17:24 +02:00
Justin Traglia 3c7544af3d Add invalid large withdrawable epoch test 2022-05-06 13:56:40 -05:00
Danny Ryan c1d0836936
Merge pull request #2855 from ethereum/00-to-01
00 to 01 cred change
2022-05-05 07:31:49 -06:00
Michael Sproul 3f76792ee3
Require fork choice to run before proposal 2022-05-05 11:21:55 +10:00
Hsiao-Wei Wang 8a4ea1d13d
Merge pull request #2877 from zilm13/fix/equivocating-indices
Yield attestation in equivocating indices test
2022-05-03 14:44:57 +02:00
Hsiao-Wei Wang 9e09e9664e
Merge pull request #2876 from etan-status/fix-prepare-payload
Fix param order in `prepare_execution_payload`
2022-05-03 13:05:54 +02:00
Etan Kissling 5653649ca8
Allow light client to verify signatures at period boundary
As the sync committee signs the previous block, the situation arises at
every sync committee period boundary, that the new sync committee signs
a block in the previous sync committee period. The light client cannot
reliably detect this condition (e.g., assume that this is the case when
it is currently on the last slot of a sync committee period), because
the last couple slots of a sync committee period may not have a block.

For example, when receiving a `LightClientUpdate` that is constructed
as in the following illustration, it is unknown whether `sync_aggregate`
was signed by the current or next sync committee at `attested_header`.

```

        slot N           N + 1   |            N + 2   (slot not sent!)
                                 |
  +-----------------+     \ /    |     +----------------+
  | attested_header | <--- X ----|---- | sync_aggregate |
  +-----------------+     / \    |     +----------------+
                        missed   |
                                 |
                          sync committee
                          period boundary
```

This patch addresses this edge case by including the slot at which the
`sync_aggregate` was created into the `LightClientUpdate` object.

Note that the `signature_slot` cannot be trusted beyond the purpose of
signature verification, as it could be manipulated to any other slot
within the same sync committee period and fork version, without making
the `sync_aggregate` invalid.
2022-05-02 13:08:20 +02:00
Mikhail Kalinin 83bf20cbd4
Merge pull request #2881 from ethereum/mkalinin-patch-2
Remove justified block from optimistic candidate conditions
2022-04-29 19:09:02 +04:00
Mikhail Kalinin 706f417ba0
Remove justified from optimistic import conditions 2022-04-28 13:17:19 +04:00
Dmitrii Shmatko b9cb294650 Yield attestation in equivocating indices test 2022-04-25 23:23:44 +03:00
Etan Kissling f125538122
Fix param order in `prepare_execution_payload`
Documentation on how to call `prepare_execution_payload` had the params
for `safe_block_hash` and `finalized_block` hash flipped compared to the
function definition. Also updated tests for consistency.
2022-04-25 16:49:00 +02:00
Hsiao-Wei Wang 83ac38c183
Merge pull request #2872 from benjaminion/patch-1 2022-04-17 08:00:33 -07:00
Hsiao-Wei Wang f8bf3d3119
Merge pull request #2870 from ethereum/eip4844-typo 2022-04-17 07:58:54 -07:00
Ben Edgington eca7237b27
Correct typo: BLSCommitment -> KZGCommitment
The consensus chain counterpart to https://github.com/ethereum/EIPs/pull/4992. The same comment from there applies here as well.
2022-04-13 15:04:55 +01:00
Hsiao-Wei Wang dcf41ef5e2 Merge branch 'dev' into eip4844-typo 2022-04-12 22:14:37 +08:00
Hsiao-Wei Wang 49e4b2bc87
Merge pull request #2868 from ethereum/fix-capella-validator
Fix Capella `prepare_execution_payload`
2022-04-12 07:13:55 -07:00
Hsiao-Wei Wang 5978c86f3a
Typo fix: `ksg_to_version_hash` -> `kzg_to_versioned_hash` 2022-04-10 18:41:49 +08:00
Hsiao-Wei Wang 6576cab612 Fix Capella `prepare_execution_payload` 2022-04-06 18:13:39 +08:00
Danny Ryan 1bfefe301d
Merge pull request #2858 from mkalinin/justified-to-safe-block
Bellatrix: pass justified as a safe block
2022-03-30 12:19:21 -06:00
Danny Ryan c87fc48053
minor typo 2022-03-30 12:04:23 -06:00
Mikhail Kalinin b13a9f0f8a Apply suggestions as per review 2022-03-30 15:36:01 +06:00
Hsiao-Wei Wang 70aba238b4
Merge pull request #2863 from terencechain/patch-134
EIP4844: fix a typo
2022-03-29 06:30:48 -07:00
terence tsao eb26a1d74c
EIP4844: fix a minor typo 2022-03-26 08:26:52 -07:00
Danny Ryan 19613ac7cd
Merge pull request #2854 from ralexstokes/update-0x01-creds
Update 0x01 withdrawal credentials.
2022-03-25 16:27:41 -06:00
Mikhail Kalinin bd66114f4a Clarify names and move get_safe_block_hash to safe-block.md 2022-03-26 02:02:38 +06:00
Danny Ryan 656e6aef21
Merge pull request #2836 from ethereum/withdrawals-push
Withdrawals push
2022-03-24 10:08:29 -06:00
Danny Ryan ee5f29cb75
fix ci 2022-03-24 09:57:43 -06:00
Mikhail Kalinin c97cc6f4dc Add separate get_safe_beacon_block function 2022-03-24 17:22:11 +06:00
Mikhail Kalinin bc95973232
Reorder params
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2022-03-24 16:35:28 +06:00
Danny Ryan 6e369e4a53
Apply suggestions from code review
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2022-03-23 10:55:27 -06:00
Danny Ryan 4ac4158b42
move bls chang operation to end of block body 2022-03-23 10:54:40 -06:00
Hsiao-Wei Wang 2d0a30649b
Merge pull request #2860 from jtraglia/fix-makefile-indentation
Fix indententation for one line in the Makefile
2022-03-23 03:05:55 -07:00
Hsiao-Wei Wang 8a388f2226 toc 2022-03-23 15:38:17 +08:00
Justin Traglia 4c89fdb9b9 Fix indententation for one line in the Makefile
Real minor fix. Rule lines should start with a single tab, not spaces. Vim
clearly pointed this out by marking the entire line as red.
2022-03-22 15:05:56 -05:00
Danny Ryan 2017b61265
test address_change 2022-03-22 13:37:17 -06:00
Mikhail Kalinin 046eaf2ea0 Bellatrix: remove a comment about safe head stub 2022-03-22 22:53:47 +06:00
Mikhail Kalinin 95a2327800 Bellatrix: add get_safe_block_hash to validator.md 2022-03-22 22:51:45 +06:00