82b7a7be3b
Apply suggestions from code review
...
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Jacek Sieka <jacek@status.im>
2021-05-12 08:29:42 -06:00
488ceed4f9
add notes about repeatedly failing tos erve blocks as being disconncetable
2021-05-11 11:29:37 -06:00
5792afca46
Merge branch 'dev' into bbr-ws
2021-05-11 09:51:57 -06:00
c7166a37af
change eth1data block_hash type to Hash32 in phase 0
2021-04-15 06:47:11 -05:00
b2f42bf4d7
broadast -> broadcast
2021-04-05 17:05:59 -07:00
ed6358a719
Merge pull request #2248 from hukkinj1/dev
...
Fix list indentation
2021-03-30 07:32:35 -06:00
07b7774241
misc. phase1 modules refactor updates
2021-03-30 01:46:02 +02:00
b23b16c7b7
Fix list indentation
2021-03-29 01:10:36 +03:00
020895e35d
Typing problems fixes ( #2271 )
...
* Typing problem fixed: `process_block_header` passes `Bytes32()` to `state_root` of `BeaconBlockHeader`, which type is `Root`
* Typing problem fixed in `initialize_beacon_state_from_eth1`: `len` returns an `int` value, while `deposit_count=uint64` of `Eth1Data` has type `uint64`
* Typing problem fixed in `process_rewards_and_penalties`: `numerator` of type `int` passed to `weight` parameter of `get_flag_index_deltas`, which has type `uint64`
* Typing problem fixed in `process_attestation`; `False` passes as `crosslink_success` parameter of `PendingAttestation`, which has type `boolean`. `False` is an instance of `(python.)bool` and is not an instance of `(ssz.)boolean`
* Typing problem fixed: `shard_data_roots` of `ShardTransition` has type `List[Bytes32]`, but its elements are used as if they were `Root` values, e.g. in `process_chunk_challenge` method: passed to `data_root` of `CustodyChunkChallengeRecord` which has type `Root`
* Typing problem fixed in `process_custody_final_updates`: `index` has type `int`, while `validator_indices_in_records` has type `Set[ValidatorIndex]`, so tesing whether `index in validator_indices_in_records` can be risky, depending on implementation details. `ValidatorIndex(index) in validator_indices_in_records` is a safer variant.
* Typing problem fixed: `slashed` parameter of `pack_compact_validator` has type `(python.)bool`, however in `committee_to_compact_committee` a value of `(ssz.)boolean` is passed as a value of the parameter
* Typing problem fixed: `inactivity_scores` is a `List[uint64,...]`, while it is intialized/appended with values of `(python.)int` type
* fixed according to @protolambda suggestions
* changed types of _WEIGHT constants and appropriate variables/parameters, according to @protolambda suggestions
* revert code formatting back
* Introduced ZERO_ROOT according to @protolambda 's suggestion
* Reverted back to , according to @protolambda comments
2021-03-25 22:03:21 +01:00
bb85ef5a57
pr cleanup
2021-03-22 10:53:26 -06:00
493dd17cc4
reduce justification and finalization Altair diff
2021-03-21 04:22:45 +01:00
c661ddf12c
hoist container definitions to preamble
2021-03-17 09:35:39 -06:00
b8bf7f0f80
Merge pull request #2236 from ethereum/justin_altair_cleanups
...
Altair cosmetic cleanups plus a couple substantive changes
2021-03-15 08:57:35 -06:00
e7ebd08d69
Altair cosmetic cleanups plus a couple substantive changes
2021-03-15 11:08:41 +00:00
dd341adc20
remove faulty de-duplication condition for seen aggregates
2021-03-10 18:55:21 -07:00
e1023f55d1
Fix a small typo
2021-03-05 18:05:15 -08:00
63e014791c
Merge branch 'dev' into dev-merge
2021-02-24 16:23:04 -07:00
396d399129
Apply suggestions from code review form @hwwhww
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-02-24 08:53:54 -06:00
b789b10397
Minor update ToC
2021-02-23 16:31:19 -07:00
1f7e9fabf2
minor 0x01 PR feedback
2021-02-23 16:16:46 -07:00
a0ae048395
copy edits
2021-02-23 16:16:46 -07:00
5992e8ff05
Update deposit-contract.md
2021-02-23 16:16:46 -07:00
809fc7afaf
Update validator.md
2021-02-23 16:16:45 -07:00
1f8ca7179f
Update validator.md
2021-02-23 16:16:45 -07:00
80613a99bd
Update validator.md
2021-02-23 16:16:45 -07:00
0f94fa51b8
Update validator.md
2021-02-23 16:16:45 -07:00
e93f1e1fa8
Copy-edit deposit-contract.md
2021-02-23 16:16:45 -07:00
47ebf438b3
Cleaner section title
...
"Withdrawal prefixes" matches `[BLS]/[ETH1_ADDRESS]_WITHDRAWAL_PREFIX`
2021-02-23 16:16:45 -07:00
128efdd34d
Fix table for withdrawal credentials prefixes
...
Minor cosmetic fixes (misformated table, section title).
2021-02-23 16:16:45 -07:00
7af50cc827
add eth1 withdrawal credentials to spec
2021-02-23 16:16:35 -07:00
8ec082fcf9
Merge pull request #2149 from ethereum/0x01-creds
...
Eth1 withdrawal credentials (0x01)
2021-02-16 13:06:34 -06:00
7050cb0add
minor 0x01 PR feedback
2021-02-16 11:55:01 -07:00
7d715220bb
Don't propagate blocks with a faulty slot ( #2196 )
2021-02-10 12:39:42 -07:00
0fd0db1ffc
Fix some typos ( #2195 )
...
* Fix typo for P2P Networking document
* Fix link typo of P2P networking document
* fix typo for light clients beacon chain document
2021-02-06 06:20:35 -07:00
fe52f377e6
Merge pull request #2190 from ethereum/update-ws-calc
...
Updated Weak Subjectivity Calculations
2021-02-04 10:23:08 -06:00
8b217d9277
Fix typo
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-02-02 12:17:56 -08:00
a28f52729d
Rename variables for clarity
2021-01-27 15:58:19 -08:00
742d21e914
Updates based on review
2021-01-27 15:16:15 -08:00
1b00c10ed3
Apply @michaelsproul's feedback
2021-01-27 14:47:52 +08:00
c932fc2798
Fix linter errors
2021-01-21 17:07:45 -08:00
900eb4a83c
Fixed CI errors
2021-01-20 19:33:25 -08:00
e53213a585
Minor refactor
2021-01-20 13:06:24 +08:00
daa4798704
Break down process_final_updates
2021-01-19 21:41:55 +08:00
93c4c62900
Remove python tag from fenced code block
2021-01-19 02:04:55 -08:00
37874f9b79
Update WS calc
2021-01-19 01:53:12 -08:00
65696ca68b
fix typo: same condition, but non-aggregate attestation here
2021-01-16 22:48:22 +01:00
2ad8fdb818
add ability for node to randomly request and descore if not serving blocks on WS period
2021-01-14 06:53:04 -07:00
70e25e6390
Update specs/phase0/weak-subjectivity.md
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-01-05 21:13:35 -08:00
7d60e482b9
fix typo
2021-01-05 08:48:25 +03:00
452e3301be
Fix typo
2020-12-21 10:22:04 +00:00
f137bb037a
Merge pull request #2130 from ethereum/vbuterin-patch-2
...
Added standalone light client patch
2020-12-17 07:53:33 -06:00
acfe49e3f3
executable light client patch: beacon-chain.md ( #2141 )
...
* Bump remerkleable to 0.1.18
* Disable `sync-protocol.md` for now. Make linter pass
* Enable lightclient tests
* Use *new* `optional_fast_aggregate_verify`
* Fix ToC and codespell
* Do not run phase1 tests with Lightclient patch
* Fix the Eth1Data casting bug. Add a workaround.
* Fix `run_on_attestation` testing helper
* Revert
* Rename `optional_fast_aggregate_verify` to `eth2_fast_aggregate_verify`
* Apply Proto's suggestion
* Apply Danny's suggestion
* Fixing tests
* Fix after rebasing
* Rename `LIGHTCLIENT` -> `LIGHTCLIENT_PATCH`
* New doctoc
* Add lightclient patch configs
* fix gitignore light client patch generator output
* Upgrade state for light client patch
* Add `lightclient-fork.md` to deal the fork boundary and fix
`process_block_header`
* Misc cleanups
1) Add a summary note for every function that is changed.
2) Avoid changing `process_block` (instead only change `process_block_header`).
3) Rename `G2_INFINITY_POINT_SIG` to `G2_POINT_AT_INFINITY` to avoid `SIG` contraction.
4) Misc cleanups
* Update block.py
* Update beacon-chain.md
* Fix typo "minimal" -> "mainnet"
Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com>
* Use the new `BeaconBlockHeader` instead of phase 0 version
* Update config files
* Move `sync_committee_bits` and `sync_committee_signature` back to `BeaconBlockBody`
Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: Justin <drakefjustin@gmail.com>
Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com>
2020-12-15 13:18:20 +08:00
2c90ffa2f4
copy edits
2020-12-14 13:09:25 -07:00
645a3851af
Update deposit-contract.md
2020-12-12 22:02:56 +00:00
85c1347ffc
Update validator.md
2020-12-12 21:57:58 +00:00
f9edecf23c
Update validator.md
2020-12-12 21:56:30 +00:00
b085436f2f
Update validator.md
2020-12-12 21:51:21 +00:00
ae0b10edb7
Update validator.md
2020-12-12 21:46:39 +00:00
2cc9a12c98
Copy-edit deposit-contract.md
2020-12-12 20:50:10 +00:00
ef3802b8e7
Cleaner section title
...
"Withdrawal prefixes" matches `[BLS]/[ETH1_ADDRESS]_WITHDRAWAL_PREFIX`
2020-12-12 20:40:59 +00:00
784e567d4b
Fix table for withdrawal credentials prefixes
...
Minor cosmetic fixes (misformated table, section title).
2020-12-12 20:38:40 +00:00
6b728c1880
add eth1 withdrawal credentials to spec
2020-12-11 15:03:58 -07:00
56aafbe533
add note about signature check when backfilling beaconblocks
2020-12-09 12:37:56 -07:00
17221c8065
more clearly define min epoch range for blocksbyrange requests
2020-12-09 12:27:01 -07:00
f2fe390638
secret_key => privkey
2020-12-08 09:20:50 +00:00
0b9e80d1eb
grammar
2020-12-07 23:15:34 +08:00
56048cbf56
Cosmetic cleanups to BLS signatures section
...
Miscellaneous cosmetic cleanups to the " BLS signatures" section:
1) fix section capitalisation for spec consistency
2) avoid uncapitalised "eth2" for spec consistency
3) avoid contractions (such as `PK` for `pubkey`) for spec consistency
4) various copyedits
2020-12-07 07:28:01 -07:00
64412be0d7
Minor update ToC
2020-12-07 11:10:19 +08:00
7589af8e8d
remove wip notice on phase 0 specs
2020-11-04 09:30:29 -06:00
cd7b1056b4
add mainnet deposit contract address and min genesis time
2020-11-04 09:11:52 -06:00
2aa827c07f
Merge pull request #2107 from bloxapp/honest_val_time_attack
...
added best practices section according to https://github.com/ethereum …
2020-11-04 07:36:27 -06:00
6996a897b5
Apply suggestions from code review
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2020-11-04 15:29:06 +02:00
5b95219d18
Apply suggestions from code review
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2020-11-04 15:19:41 +02:00
cfc91cdef7
Merge pull request #2121 from AgeManning/gossipsub-mesh
...
Increase gossipsub mesh degree
2020-11-04 06:59:59 -06:00
82cdbba703
Increase mesh degree
2020-11-04 11:27:35 +11:00
c4ccdc90de
Merge branch 'dev' into v1.0-candidate
2020-11-03 17:09:48 -06:00
6b44f63751
Merge pull request #2104 from ethereum/state_transition_patch
...
Make `state_transition` not return post-state
2020-11-03 14:57:29 -06:00
bfaef689e4
Merge pull request #2092 from ethereum/ralexstokes-patch-1
...
Simplify fork choice spec
2020-11-03 06:58:35 -07:00
b356f52c5c
ensure aggregate attestation's slot and target are consistent
2020-10-28 17:54:46 -06:00
0835c78b56
Apply suggestions from Dankrad's code review
...
Co-authored-by: dankrad <mail@dankradfeist.de>
2020-10-27 08:38:54 +02:00
fe5e2f6a8b
table of content
2020-10-20 12:07:54 +03:00
73cd1a84fd
added best practices section according to https://github.com/ethereum/eth2.0-specs/issues/2085
2020-10-20 12:00:40 +03:00
7fb9226ec6
Make `state_transition` not return post state; the given pre state should have been mutated to post state.
2020-10-15 15:58:26 +08:00
c17a95a175
add note about how slashings and exits can interact. add test
2020-10-14 17:33:14 -06:00
427c7bb236
fix minor typo in validator guide
2020-10-08 10:18:15 -06:00
91deacbf9c
double eth1data params
2020-10-07 18:52:47 -06:00
663af77737
Clean up unused variable for linter
2020-10-07 17:11:13 -07:00
d0cf4e7bad
Simplify fork choice spec
...
This change should be non-substantive as any blocks in `blocks` should be descendants (inclusive) of the `store.justified_checkpoint` (refer `get_filtered_block_tree`) so that in `get_head` all blocks considered as potential heads will have `slot > justified_slot`. Considering this condition universally applies, adding the `and ...` arm to the conditional is unnecessary overhead.
2020-10-07 16:52:51 -07:00
d3d9bbd479
add note about coming gs v1.1 params
2020-10-07 17:46:20 -06:00
45de8198ca
Merge branch 'dev' into v1.0-candidate
2020-10-07 13:42:23 -06:00
64b34b5ca6
Merge pull request #2089 from ethereum/fix-message-id
...
fix message-id issues
2020-10-07 12:40:51 -06:00
8cda237884
note v5.1 in discv5 p2p spec
2020-10-07 12:13:32 -06:00
6287875baf
use domain byte to isolate message-id domains
2020-10-07 11:59:39 -06:00
a365fcb03b
fix message-id issues
2020-10-06 16:18:12 -06:00
d264ad8af7
Merge pull request #2080 from ethereum/bls_v4
...
Bump IETF BLS spec version draft 03 -> draft 04
2020-10-05 22:12:52 +08:00
5f9e6599e9
Merge pull request #2060 from protolambda/signing-policy
...
Use gossip signing policy in p2p spec, see libp2p/specs#294
2020-09-30 12:03:21 -06:00
157f7e8ef4
upgrade config to mainnet values
2020-09-28 12:56:08 -06:00
62d596a910
update signature policy link
2020-09-25 17:59:09 +02:00
ad4ad2d8b4
Bump IETF BLS spec version draft 03 -> draft 04
2020-09-25 15:01:41 +08:00
8c9c943845
Merge pull request #2054 from ethereum/ralexstokes-patch-1
...
Typos in: p2p-interface.md
2020-09-22 17:32:10 -06:00
Danny Ryan
terence tsao
protolambda
Taneli Hukkinen
Alex Vlasov
Alex Stokes
Justin Drake
Hsiao-Wei Wang
Paul Hauner
Phong Phan
Aditya Asgaonkar
Aditya Asgaonkar
Hsiao-Wei Wang
Victor Farazdagi
Ben Edgington
Alon Muroch
Age Manning