From 50209ea806820f83ceff3f21e1578191db0a71e5 Mon Sep 17 00:00:00 2001
From: vbuterin <v@buterin.com>
Date: Sun, 22 Sep 2019 10:09:10 +0300
Subject: [PATCH 1/2] Refactor Merkle proof verification

Goal: support calculating roots of trees modified by setting new leaves
---
 specs/light_client/merkle_proofs.md | 28 ++++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/specs/light_client/merkle_proofs.md b/specs/light_client/merkle_proofs.md
index b920f50b1..d8b8c2464 100644
--- a/specs/light_client/merkle_proofs.md
+++ b/specs/light_client/merkle_proofs.md
@@ -282,23 +282,27 @@ def get_helper_indices(indices: Sequence[GeneralizedIndex]) -> Sequence[Generali
 Now we provide the Merkle proof verification functions. First, for single item proofs:
 
 ```python
-def verify_merkle_proof(leaf: Hash, proof: Sequence[Hash], index: GeneralizedIndex, root: Hash) -> bool:
+def calculate_merkle_root(leaf: Hash, proof: Sequence[Hash], index: GeneralizedIndex) -> Hash:
     assert len(proof) == get_generalized_index_length(index)
     for i, h in enumerate(proof):
         if get_generalized_index_bit(index, i):
             leaf = hash(h + leaf)
         else:
             leaf = hash(leaf + h)
-    return leaf == root
+    return leaf
+```
+
+```python
+def verify_merkle_proof(leaf: Hash, proof: Sequence[Hash], index: GeneralizedIndex, root: Hash) -> bool:
+    return calculate_merkle_root(leaf, proof, index) == root
 ```
 
 Now for multi-item proofs:
 
 ```python
-def verify_merkle_multiproof(leaves: Sequence[Hash],
-                             proof: Sequence[Hash],
-                             indices: Sequence[GeneralizedIndex],
-                             root: Hash) -> bool:
+def calculate_multi_merkle_root(leaves: Sequence[Hash],
+                                proof: Sequence[Hash],
+                                indices: Sequence[GeneralizedIndex]) -> Hash:
     assert len(leaves) == len(indices)
     helper_indices = get_helper_indices(indices)
     assert len(proof) == len(helper_indices)
@@ -317,7 +321,15 @@ def verify_merkle_multiproof(leaves: Sequence[Hash],
             )
             keys.append(GeneralizedIndex(k // 2))
         pos += 1
-    return objects[GeneralizedIndex(1)] == root
+    return objects[GeneralizedIndex(1)]
 ```
 
-Note that the single-item proof is a special case of a multi-item proof; a valid single-item proof verifies correctly when put into the multi-item verification function (making the natural trivial changes to input arguments, `index -> [index]` and `leaf -> [leaf]`).
+```python
+def verify_merkle_multiproof(leaves: Sequence[Hash],
+                             proof: Sequence[Hash],
+                             indices: Sequence[GeneralizedIndex],
+                             root: Hash) -> bool:
+    return calculate_multi_merkle_root(leaf, proof, index) == root
+```
+
+Note that the single-item proof is a special case of a multi-item proof; a valid single-item proof verifies correctly when put into the multi-item verification function (making the natural trivial changes to input arguments, `index -> [index]` and `leaf -> [leaf]`). Note also that `calculate_merkle_root` and `calculate_multi_merkle_root` can be used independently to compute the new Merkle root of a proof with leaves updated.

From ce1ceee9af5c638d70295b2688321ef5f8caa953 Mon Sep 17 00:00:00 2001
From: Diederik Loerakker <proto@protolambda.com>
Date: Wed, 23 Oct 2019 17:23:46 +0800
Subject: [PATCH 2/2] Fix argument names, PR suggestion from @wemeetagain

Co-Authored-By: Cayman <caymannava@gmail.com>
---
 specs/light_client/merkle_proofs.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/specs/light_client/merkle_proofs.md b/specs/light_client/merkle_proofs.md
index d8b8c2464..24d3b637b 100644
--- a/specs/light_client/merkle_proofs.md
+++ b/specs/light_client/merkle_proofs.md
@@ -329,7 +329,7 @@ def verify_merkle_multiproof(leaves: Sequence[Hash],
                              proof: Sequence[Hash],
                              indices: Sequence[GeneralizedIndex],
                              root: Hash) -> bool:
-    return calculate_multi_merkle_root(leaf, proof, index) == root
+    return calculate_multi_merkle_root(leaves, proof, indices) == root
 ```
 
 Note that the single-item proof is a special case of a multi-item proof; a valid single-item proof verifies correctly when put into the multi-item verification function (making the natural trivial changes to input arguments, `index -> [index]` and `leaf -> [leaf]`). Note also that `calculate_merkle_root` and `calculate_multi_merkle_root` can be used independently to compute the new Merkle root of a proof with leaves updated.