From 01eaf6cc99091292a5778cc7d5828e544bab8561 Mon Sep 17 00:00:00 2001 From: Danny Ryan Date: Fri, 8 May 2020 11:09:12 -0600 Subject: [PATCH 1/2] Clarify the response of BlocksByRange to address #1765 --- specs/phase0/p2p-interface.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/specs/phase0/p2p-interface.md b/specs/phase0/p2p-interface.md index d697e5da3..dae82f464 100644 --- a/specs/phase0/p2p-interface.md +++ b/specs/phase0/p2p-interface.md @@ -537,7 +537,9 @@ The response MUST contain no more than `count` blocks. Clients MUST order blocks by increasing slot number. -Clients MUST respond with blocks from their view of the current fork choice. In particular, blocks from slots before the finalization MUST lead to the finalized block reported in the `Status` handshake. +Clients MUST respond with blocks from their view of the current fork choice -- that is, blocks from the single chain defined by the current head. Of note, blocks from slots before the finalization MUST lead to the finalized block reported in the `Status` handshake. + +Clients MUST respond with blocks that are consistent from a single chain within the context of the request. #### BeaconBlocksByRoot From b4bc2038e1a7727a18d05c8543504b7d7344cb8a Mon Sep 17 00:00:00 2001 From: Danny Ryan Date: Mon, 11 May 2020 08:39:30 -0600 Subject: [PATCH 2/2] clarify that clients MAY stop block requests if fork choice changes --- specs/phase0/p2p-interface.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/phase0/p2p-interface.md b/specs/phase0/p2p-interface.md index dae82f464..399e1b466 100644 --- a/specs/phase0/p2p-interface.md +++ b/specs/phase0/p2p-interface.md @@ -539,7 +539,7 @@ Clients MUST order blocks by increasing slot number. Clients MUST respond with blocks from their view of the current fork choice -- that is, blocks from the single chain defined by the current head. Of note, blocks from slots before the finalization MUST lead to the finalized block reported in the `Status` handshake. -Clients MUST respond with blocks that are consistent from a single chain within the context of the request. +Clients MUST respond with blocks that are consistent from a single chain within the context of the request. After the initial block clients MAY stop in the process of responding, if their fork choice changes the view of the chain in the context of the request. #### BeaconBlocksByRoot