From 7d8570d48871b82e260ca09454299fc5edf7ef2a Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 14 Apr 2021 12:53:30 +0600 Subject: [PATCH] Warn about potential overflows in compute_time_at_slot --- specs/merge/beacon-chain.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/specs/merge/beacon-chain.md b/specs/merge/beacon-chain.md index 2dc1bbc84..028eb5b84 100644 --- a/specs/merge/beacon-chain.md +++ b/specs/merge/beacon-chain.md @@ -168,6 +168,8 @@ def is_transition_block(state: BeaconState, block_body: BeaconBlockBody) -> bool #### `compute_time_at_slot` +*Note*: This function is unsafe with respect to overflows and underflows. + ```python def compute_time_at_slot(state: BeaconState, slot: Slot) -> uint64: slots_since_genesis = slot - GENESIS_SLOT