From 73279f8382230bc3eb5a48ffd28ac0c27f57b359 Mon Sep 17 00:00:00 2001 From: Etan Kissling Date: Fri, 15 Jul 2022 12:21:48 +0200 Subject: [PATCH] Explain why the tests check for Altair twice --- .../test/altair/sync_protocol/test_light_client_sync.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/core/pyspec/eth2spec/test/altair/sync_protocol/test_light_client_sync.py b/tests/core/pyspec/eth2spec/test/altair/sync_protocol/test_light_client_sync.py index aa8c9950a..0df77cda4 100644 --- a/tests/core/pyspec/eth2spec/test/altair/sync_protocol/test_light_client_sync.py +++ b/tests/core/pyspec/eth2spec/test/altair/sync_protocol/test_light_client_sync.py @@ -104,7 +104,7 @@ def compute_start_slot_at_next_sync_committee_period(spec, state): @with_presets([MINIMAL], reason="too slow") def test_light_client_sync(spec, state): if state.fork.current_version == spec.config.GENESIS_FORK_VERSION: - return # Test requires Altair or later + return # Test requires Altair or later (`make test` does not honor phases) # Start test test = yield from setup_test(spec, state) @@ -321,7 +321,7 @@ def test_light_client_sync(spec, state): @with_presets([MINIMAL], reason="too slow") def test_supply_sync_committee_from_past_update(spec, state): if state.fork.current_version == spec.config.GENESIS_FORK_VERSION: - return # Test requires Altair or later + return # Test requires Altair or later (`make test` does not honor phases) # Advance the chain, so that a `LightClientUpdate` from the past is available next_slots(spec, state, spec.SLOTS_PER_EPOCH * 2 - 1) @@ -353,7 +353,7 @@ def test_supply_sync_committee_from_past_update(spec, state): @with_presets([MINIMAL], reason="too slow") def test_advance_finality_without_sync_committee(spec, state): if state.fork.current_version == spec.config.GENESIS_FORK_VERSION: - return # Test requires Altair or later + return # Test requires Altair or later (`make test` does not honor phases) # Start test test = yield from setup_test(spec, state)