From 93cb17dc7f14114e382e1657841d22cdc885c0ff Mon Sep 17 00:00:00 2001 From: terence tsao Date: Thu, 29 Sep 2022 07:36:39 -0700 Subject: [PATCH 1/3] Eip4844: various fixes --- specs/eip4844/p2p-interface.md | 13 +++++-------- specs/eip4844/validator.md | 2 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/specs/eip4844/p2p-interface.md b/specs/eip4844/p2p-interface.md index 5c9c46f2c..081337dbd 100644 --- a/specs/eip4844/p2p-interface.md +++ b/specs/eip4844/p2p-interface.md @@ -33,10 +33,10 @@ The specification of these changes continues in the same format as the network s ## Configuration -| Name | Value | Description | -|------------------------------------------|-------------------------------|---------------------------------------------------------------------| -| `MAX_REQUEST_BLOBS_SIDECARS` | `2**7` (= 128) | Maximum number of blobs sidecars in a single request | -| `MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` | `2**13` (= 8192, ~1.2 months) | The minimum epoch range over which a node must serve blobs sidecars | +| Name | Value | Description | +|------------------------------------------|------------------------------------|---------------------------------------------------------------------| +| `MAX_REQUEST_BLOBS_SIDECARS` | `2**7` (= 128) | Maximum number of blobs sidecars in a single request | +| `MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` | `2**13epoch` (= 8192, ~1.2 months) | The minimum epoch range over which a node must serve blobs sidecars | ## Containers @@ -207,10 +207,7 @@ or disconnected at any time. *Note*: The above requirement implies that nodes that start from a recent weak subjectivity checkpoint MUST backfill the local blobs database to at least epoch `current_epoch - MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` -to be fully compliant with `BlobsSidecarsByRange` requests. To safely perform such a -backfill of blocks to the recent state, the node MUST validate both (1) the -proposer signatures and (2) that the blocks form a valid chain up to the most -recent block referenced in the weak subjectivity state. +to be fully compliant with `BlobsSidecarsByRange` requests. *Note*: Although clients that bootstrap from a weak subjectivity checkpoint can begin participating in the networking immediately, other peers MAY diff --git a/specs/eip4844/validator.md b/specs/eip4844/validator.md index a1faffa25..c29a7c414 100644 --- a/specs/eip4844/validator.md +++ b/specs/eip4844/validator.md @@ -245,7 +245,7 @@ def get_signed_blobs_sidecar(state: BeaconState, blobs_sidecar: BlobsSidecar, pr return SignedBlobsSidecar(message=blobs_sidecar, signature=signature) ``` -This `signed_blobs_sidecar` is then published to the global `blobs_sidecar` topic as soon as the `beacon_block` is published. +This `signed_blobs_sidecar` is then published to the global `blobs_sidecar` topic as soon as the `signed_beacon_block` is published. After publishing the sidecar peers on the network may request the sidecar through sync-requests, or a local user may be interested. The validator MUST hold on to blobs for `MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` epochs and serve when capable, From 06c91e4843ea3675b4de7e10e1fd5e662e677741 Mon Sep 17 00:00:00 2001 From: terence tsao Date: Thu, 29 Sep 2022 07:53:52 -0700 Subject: [PATCH 2/3] Try a different format for epoch --- specs/eip4844/p2p-interface.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specs/eip4844/p2p-interface.md b/specs/eip4844/p2p-interface.md index 081337dbd..7be539b40 100644 --- a/specs/eip4844/p2p-interface.md +++ b/specs/eip4844/p2p-interface.md @@ -33,10 +33,10 @@ The specification of these changes continues in the same format as the network s ## Configuration -| Name | Value | Description | -|------------------------------------------|------------------------------------|---------------------------------------------------------------------| -| `MAX_REQUEST_BLOBS_SIDECARS` | `2**7` (= 128) | Maximum number of blobs sidecars in a single request | -| `MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` | `2**13epoch` (= 8192, ~1.2 months) | The minimum epoch range over which a node must serve blobs sidecars | +| Name | Value | Description | +|------------------------------------------|-------------------------------------|---------------------------------------------------------------------| +| `MAX_REQUEST_BLOBS_SIDECARS` | `2**7` (= 128) | Maximum number of blobs sidecars in a single request | +| `MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` | `2**13` (= 8192epochs, ~1.2 months) | The minimum epoch range over which a node must serve blobs sidecars | ## Containers From 779e6e7b7e18781418f11df423e6ad18955a93bd Mon Sep 17 00:00:00 2001 From: terencechain Date: Thu, 29 Sep 2022 13:43:28 -0700 Subject: [PATCH 3/3] Update specs/eip4844/p2p-interface.md Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com> --- specs/eip4844/p2p-interface.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/eip4844/p2p-interface.md b/specs/eip4844/p2p-interface.md index 7be539b40..eab8815a4 100644 --- a/specs/eip4844/p2p-interface.md +++ b/specs/eip4844/p2p-interface.md @@ -36,7 +36,7 @@ The specification of these changes continues in the same format as the network s | Name | Value | Description | |------------------------------------------|-------------------------------------|---------------------------------------------------------------------| | `MAX_REQUEST_BLOBS_SIDECARS` | `2**7` (= 128) | Maximum number of blobs sidecars in a single request | -| `MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` | `2**13` (= 8192epochs, ~1.2 months) | The minimum epoch range over which a node must serve blobs sidecars | +| `MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS` | `2**13` (= 8192 epochs, ~1.2 months) | The minimum epoch range over which a node must serve blobs sidecars | ## Containers