From 3247bcf8f721cef4b88deac6b3e22c18fbf815eb Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Tue, 23 May 2023 15:16:12 +0800 Subject: [PATCH] PR feedback from @ppopth --- specs/bellatrix/beacon-chain.md | 2 +- specs/deneb/beacon-chain.md | 17 +---------------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/specs/bellatrix/beacon-chain.md b/specs/bellatrix/beacon-chain.md index a4c7be16e..9df07d69f 100644 --- a/specs/bellatrix/beacon-chain.md +++ b/specs/bellatrix/beacon-chain.md @@ -330,7 +330,7 @@ The Engine API may be used to implement this and similarly defined functions via ```python def notify_new_payload(self: ExecutionEngine, new_payload_request: NewPayloadRequest) -> bool: """ - Return ``True`` if and only if ``execution_payload`` is valid with respect to ``self.execution_state``. + Return ``True`` if and only if ``new_payload_request`` is valid with respect to ``self.execution_state``. """ ... ``` diff --git a/specs/deneb/beacon-chain.md b/specs/deneb/beacon-chain.md index 2c4bb6133..20455ab0d 100644 --- a/specs/deneb/beacon-chain.md +++ b/specs/deneb/beacon-chain.md @@ -30,7 +30,6 @@ - [Modified `NewPayloadRequest`](#modified-newpayloadrequest) - [Engine APIs](#engine-apis) - [Modified `notify_new_payload`](#modified-notify_new_payload) - - [Block processing](#block-processing) - [Execution payload](#execution-payload) - [`process_execution_payload`](#process_execution_payload) - [Testing](#testing) @@ -182,25 +181,11 @@ class NewPayloadRequest(object): ```python def notify_new_payload(self: ExecutionEngine, new_payload_request: NewPayloadRequest) -> bool: """ - Return ``True`` if and only if ``execution_payload`` is valid with respect to ``self.execution_state``. + Return ``True`` if and only if ``new_payload_request`` is valid with respect to ``self.execution_state``. """ ... ``` -### Block processing - -```python -def process_block(state: BeaconState, block: BeaconBlock) -> None: - process_block_header(state, block) - if is_execution_enabled(state, block.body): - process_withdrawals(state, block.body.execution_payload) - process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in Deneb] - process_randao(state, block.body) - process_eth1_data(state, block.body) - process_operations(state, block.body) - process_sync_aggregate(state, block.body.sync_aggregate) -``` - #### Execution payload ##### `process_execution_payload`