From 18bfe3555f7b6b7f856096af0678085fdde30357 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 22 Sep 2021 17:45:26 +0600 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Danny Ryan --- specs/merge/beacon-chain.md | 2 +- specs/merge/fork-choice.md | 1 + specs/merge/validator.md | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/specs/merge/beacon-chain.md b/specs/merge/beacon-chain.md index a5fc4101d..6a5a2730b 100644 --- a/specs/merge/beacon-chain.md +++ b/specs/merge/beacon-chain.md @@ -239,7 +239,7 @@ The implementation-dependent `ExecutionEngine` protocol encapsulates the executi * a state object `self.execution_state` of type `ExecutionState` * a state transition function `self.execute_payload` which applies changes to the `self.execution_state` -* a method `self.consensus_validated` which notifies that the block holding the execution payload +* a method `self.consensus_validated` which signals that the beacon block containing the execution payload is valid with respect to the consensus rule set #### `execute_payload` diff --git a/specs/merge/fork-choice.md b/specs/merge/fork-choice.md index d8b3426ea..15d47a650 100644 --- a/specs/merge/fork-choice.md +++ b/specs/merge/fork-choice.md @@ -35,6 +35,7 @@ The following methods are added to the `ExecutionEngine` protocol for use in the #### `forkchoice_updated` +This method performs two actions *atomically*: * Re-organizes the execution payload chain and corresponding state to make `head_block_hash` the head. * Applies finality to the execution state: it irreversibly persists the chain of all execution payloads and corresponding state, up to and including `finalized_block_hash`. diff --git a/specs/merge/validator.md b/specs/merge/validator.md index 7dfcecbc1..a84384dd6 100644 --- a/specs/merge/validator.md +++ b/specs/merge/validator.md @@ -42,7 +42,7 @@ The following methods are added to the `ExecutionEngine` protocol for use as a v #### `prepare_payload` -Given the set of execution payload attributes initiates a process of building an execution payload +Given the set of execution payload attributes, `prepare_payload` initiates a process of building an execution payload on top of the execution chain tip identified by `parent_hash`. ```python @@ -59,7 +59,7 @@ def prepare_payload(self: ExecutionEngine, #### `get_payload` -Given the `payload_id` returns the most recent version of the execution payload that +Given the `payload_id`, `get_payload` returns the most recent version of the execution payload that has been built since the corresponding call to `prepare_payload` method. ```python @@ -83,7 +83,7 @@ All validator responsibilities remain unchanged other than those noted below. Na ##### ExecutionPayload -To obtain an execution payload a proposer of a block must take the following actions: +To obtain an execution payload, the proposer of a block must take the following actions: 1. Set `payload_id = prepare_execution_payload(state, pow_chain, fee_recipient, execution_engine)`, where: * `state` is the state for which `is_proposer(state, validator_index)` returns `True`