From 647e9d0ec0adf0acab687e7b6fb4f5be02ae7190 Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Mon, 18 Jul 2022 14:45:00 +0800 Subject: [PATCH] PR feedback from @ralexstokes --- specs/altair/beacon-chain.md | 2 +- specs/bellatrix/beacon-chain.md | 2 +- specs/capella/beacon-chain.md | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/specs/altair/beacon-chain.md b/specs/altair/beacon-chain.md index a14ddb4f6..79ab8d022 100644 --- a/specs/altair/beacon-chain.md +++ b/specs/altair/beacon-chain.md @@ -682,7 +682,7 @@ def process_sync_committee_updates(state: BeaconState) -> None: This helper function is only for initializing the state for pure Altair testnets and tests. -*Note*: The function `initialize_beacon_state_from_eth1` is modified: (1) using `ALTAIR_FORK_VERSION` as the current fork version, (2) utilizing the Altair `BeaconBlockBody` when constructing the initial `latest_block_header`, and (3) adding initial sync committees. +*Note*: The function `initialize_beacon_state_from_eth1` is modified: (1) using `ALTAIR_FORK_VERSION` as the previous and current fork version, (2) utilizing the Altair `BeaconBlockBody` when constructing the initial `latest_block_header`, and (3) adding initial sync committees. ```python def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, diff --git a/specs/bellatrix/beacon-chain.md b/specs/bellatrix/beacon-chain.md index b37a8ab71..983ecda23 100644 --- a/specs/bellatrix/beacon-chain.md +++ b/specs/bellatrix/beacon-chain.md @@ -399,7 +399,7 @@ def process_slashings(state: BeaconState) -> None: *Note*: The function `initialize_beacon_state_from_eth1` is modified for pure Bellatrix testing only. Modifications include: -1. Use `BELLATRIX_FORK_VERSION` as the current fork version. +1. Use `BELLATRIX_FORK_VERSION` as the previous and current fork version. 2. Utilize the Bellatrix `BeaconBlockBody` when constructing the initial `latest_block_header`. 3. Initialize `latest_execution_payload_header`. If `execution_payload_header == ExecutionPayloadHeader()`, then the Merge has not yet occurred. diff --git a/specs/capella/beacon-chain.md b/specs/capella/beacon-chain.md index ca0305f04..06659349a 100644 --- a/specs/capella/beacon-chain.md +++ b/specs/capella/beacon-chain.md @@ -495,7 +495,7 @@ def process_bls_to_execution_change(state: BeaconState, *Note*: The function `initialize_beacon_state_from_eth1` is modified for pure Capella testing only. Modifications include: -1. Use `CAPELLA_FORK_VERSION` as the current fork version. +1. Use `CAPELLA_FORK_VERSION` as the previous and current fork version. 2. Utilize the Capella `BeaconBlockBody` when constructing the initial `latest_block_header`. ```python @@ -541,7 +541,6 @@ def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, state.next_sync_committee = get_next_sync_committee(state) # Initialize the execution payload header - # If empty, will initialize a chain that has not yet gone through the Merge transition state.latest_execution_payload_header = execution_payload_header return state