status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix off-by-one in churn computations

This commit is contained in:
Mikhail Kalinin 2024-04-17 18:18:59 +06:00
parent 947767f3a9
commit 040f3f1f22
1 changed files with 29 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
specs/electra/beacon-chain.md
View File

@ -657,22 +657,24 @@ def queue_entire_balance_and_reset_validator(state: BeaconState, index: Validato
```python ```python
def compute_exit_epoch_and_update_churn(state: BeaconState, exit_balance: Gwei) -> Epoch: def compute_exit_epoch_and_update_churn(state: BeaconState, exit_balance: Gwei) -> Epoch:
earliest_exit_epoch = compute_activation_exit_epoch(get_current_epoch(state)) earliest_exit_epoch = max(state.earliest_exit_epoch, compute_activation_exit_epoch(get_current_epoch(state)))
per_epoch_churn = get_activation_exit_churn_limit(state) per_epoch_churn = get_activation_exit_churn_limit(state)
# New epoch for exits. # New epoch for exits.
if state.earliest_exit_epoch < earliest_exit_epoch: if state.earliest_exit_epoch < earliest_exit_epoch:
state.earliest_exit_epoch = earliest_exit_epoch exit_balance_to_consume = per_epoch_churn
state.exit_balance_to_consume = per_epoch_churn
if exit_balance <= state.exit_balance_to_consume:
# Exit fits in the current earliest epoch.
state.exit_balance_to_consume -= exit_balance
else: else:
# Exit doesn't fit in the current earliest epoch. exit_balance_to_consume = state.exit_balance_to_consume
balance_to_process = exit_balance - state.exit_balance_to_consume
additional_epochs, remainder = divmod(balance_to_process, per_epoch_churn) # Exit doesn't fit in the current earliest epoch.
state.earliest_exit_epoch += additional_epochs + 1 if exit_balance > exit_balance_to_consume:
state.exit_balance_to_consume = per_epoch_churn - remainder balance_to_process = exit_balance - exit_balance_to_consume
additional_epochs = (balance_to_process - 1) // per_epoch_churn + 1
earliest_exit_epoch += additional_epochs
exit_balance_to_consume += additional_epochs * per_epoch_churn
# Consume the balance and update state variables.
state.exit_balance_to_consume = exit_balance_to_consume - exit_balance
state.earliest_exit_epoch = earliest_exit_epoch
return state.earliest_exit_epoch return state.earliest_exit_epoch
``` ```
@ -681,22 +683,25 @@ def compute_exit_epoch_and_update_churn(state: BeaconState, exit_balance: Gwei)
```python ```python
def compute_consolidation_epoch_and_update_churn(state: BeaconState, consolidation_balance: Gwei) -> Epoch: def compute_consolidation_epoch_and_update_churn(state: BeaconState, consolidation_balance: Gwei) -> Epoch:
earliest_consolidation_epoch = compute_activation_exit_epoch(get_current_epoch(state)) earliest_consolidation_epoch = max(
state.earliest_consolidation_epoch, compute_activation_exit_epoch(get_current_epoch(state)))
per_epoch_consolidation_churn = get_consolidation_churn_limit(state) per_epoch_consolidation_churn = get_consolidation_churn_limit(state)
# New epoch for consolidations. # New epoch for consolidations.
if state.earliest_consolidation_epoch < earliest_consolidation_epoch: if state.earliest_consolidation_epoch < earliest_consolidation_epoch:
state.earliest_consolidation_epoch = earliest_consolidation_epoch consolidation_balance_to_consume = per_epoch_consolidation_churn
state.consolidation_balance_to_consume = per_epoch_consolidation_churn
if consolidation_balance <= state.consolidation_balance_to_consume:
# Consolidation fits in the current earliest consolidation epoch.
state.consolidation_balance_to_consume -= consolidation_balance
else: else:
# Consolidation doesn't fit in the current earliest epoch. consolidation_balance_to_consume = state.consolidation_balance_to_consume
balance_to_process = consolidation_balance - state.consolidation_balance_to_consume
additional_epochs, remainder = divmod(balance_to_process, per_epoch_consolidation_churn) # Consolidation doesn't fit in the current earliest epoch.
state.earliest_consolidation_epoch += additional_epochs + 1 if consolidation_balance > consolidation_balance_to_consume:
state.consolidation_balance_to_consume = per_epoch_consolidation_churn - remainder balance_to_process = consolidation_balance - consolidation_balance_to_consume
additional_epochs = (balance_to_process - 1) // per_epoch_consolidation_churn + 1
earliest_consolidation_epoch += additional_epochs
consolidation_balance_to_consume += additional_epochs * per_epoch_consolidation_churn
# Consume the balance and update state variables.
state.consolidation_balance_to_consume = consolidation_balance_to_consume - consolidation_balance
state.earliest_consolidation_epoch = earliest_consolidation_epoch
return state.earliest_consolidation_epoch return state.earliest_consolidation_epoch
``` ```