mirror of
https://github.com/status-im/embark-area-51.git
synced 2025-01-22 13:19:06 +00:00
Pascal Precht
df2aa30fb4
fix(core/cmd_controller): ensure webserver host and port aren't set to undefined
We've introduced a regression in6d75a4c6c4
where running `embark run` breaks due to webserver options not being defined. The reason this happened is because in the mentioned commit, we're checking given webserver options with an identity check against `null` and only set dedicated options, if that condition is true. E.g.: ``` if (options.runWebserver !== null) { webServerConfig.enabled = options.runWebserver; } ``` Unfortunately, due to one of JavaScript design flaws, this condition behaves totally different when no identity check is done, which causes Embark to break. Meaning that in JavaScript: ``` undefined != null // false undefined !== null // true ``` In other words, after the mentioned commit, the condition is true, resulting in several webserver configurations to be set to `undefined`. This conflicts at runtime when we compose webserver configurations out of user input and Embark's defaults here:dc5de7c1b4/lib/core/config.js (L392)
In other words, since webserver config options are already set to `undefined`, they don't get overridden by our config algorithm. This commit ensures that webserver config values are not set when their values are either `null` or `undefined`.
What is Embark
Embark is a framework that allows you to easily develop and deploy Decentralized Applications (DApps).
A Decentralized Application is a serverless html5 application that uses one or more decentralized technologies.
Embark currently integrates with EVM blockchains (Ethereum), Decentralized Storages (IPFS), and Decentralized communication platforms (Whisper and Orbit). Swarm is supported for deployment.
With Embark you can:
Blockchain (Ethereum)
- Automatically deploy contracts and make them available in your JS code. Embark watches for changes, and if you update a contract, Embark will automatically redeploy the contracts (if needed) and the dapp.
- Contracts are available in JS with Promises.
- Do Test Driven Development with Contracts using Javascript.
- Keep track of deployed contracts; deploy only when truly needed.
- Manage different chains (e.g testnet, private net, livenet)
- Easily manage complex systems of interdependent contracts.
Decentralized Storage (IPFS)
- Easily Store & Retrieve Data on the DApp through EmbarkJS. Including uploading and retrieving files.
- Deploy the full application to IPFS or Swarm.
Decentralized Communication (Whisper, Orbit)
- Easily send/receive messages through channels in P2P through Whisper or Orbit.
Web Technologies
- Integrate with any web technology including React, Foundation, etc..
- Use any build pipeline or tool you wish, including grunt, gulp and webpack.
$ npm -g install embark
Languages
JavaScript
86%
CSS
10.4%
HTML
2.2%
Shell
1.4%