Commit Graph

55 Commits

Author SHA1 Message Date
emizzle ae029a5959
Small fixes
Fixed issue with contract deploying for first time and having no gasLimit specified.

Optimised/refactored looping of compiled contracts.

Added body parameter type checking for `/embark-api/contract/deploy` endpoint
2018-10-23 10:37:01 +02:00
emizzle 05b324dffe
Fiddle use cases fixed
Handle use cases:

1) handle case when temp.sol doesn’t exist - due to the new saga updates, the response from retreiving a temp fiddle from the filesystem (even if it doesn’t exist) is forward to the compilation endpoint, which returns an ENOENT, and this is handled in the selector.
2) delete all code - shouldn’t return last fiddle and should compile an empty string.
3) Switch to different tab (ie contracts) then back to fiddle - previous fiddle should remain.

Also fixed an issue (most likely due to latest rebase) when deploying fiddle contracts. The gasLimit was not being specified.

Handled issue where entities stored in the state were not being put in the correct order, so a timestamp was sent with the requests and then sorted when the response was returned.
2018-10-23 10:37:00 +02:00
Iuri Matias 7532562e28
rebase fixes 2018-10-23 10:34:46 +02:00
Iuri Matias c2002e16fe
move deployment to module 2018-10-23 10:14:03 +02:00
Iuri Matias 40021f968a
move contract deployer to deploy manager 2018-10-23 10:14:02 +02:00
Iuri Matias 9c04dd8c59
add missing utils 2018-10-23 10:14:02 +02:00
Iuri Matias 1011d136a8
remove debug 2018-10-23 10:14:01 +02:00
Iuri Matias 75551aa005
first stab at refactor blockchain launcher 2018-10-23 10:14:00 +02:00
Anthony Laibe 90e1476888
Remove code dependencies to underscore 2018-10-23 10:05:24 +02:00
Jonathan Rainville d84ac05376
fix the indexOf instead by simulating what solc does 2018-10-23 10:05:22 +02:00
Jonathan Rainville 19ff41c4c3
fix duplicate dependencies and warn correctly for length 2018-10-23 10:05:22 +02:00
Jonathan Rainville 38f32804f9
make groups of dependencyCount to do async by group 2018-10-23 10:01:55 +02:00
Iuri Matias db7f3d39d3
first stab at refactor blockchain launcher 2018-10-23 09:55:10 +02:00
Iuri Matias 4e881cd291
rebase fixes 2018-10-23 09:51:58 +02:00
Iuri Matias 8ed808a101
fixes due to bad rebase 2018-10-23 09:47:41 +02:00
Iuri Matias 8136759bbb
refactor blockchain check 2018-10-23 09:39:03 +02:00
Iuri Matias 91cc554978
cleanup 2018-10-23 09:39:03 +02:00
Iuri Matias 4406dddf1e
first stab at refactor blockchain launcher 2018-10-23 09:39:02 +02:00
Jonathan Rainville 3dcee19002
fix the indexOf instead by simulating what solc does 2018-10-23 09:03:31 +02:00
Jonathan Rainville 31162882c7
fix duplicate dependencies and warn correctly for length 2018-10-23 09:03:31 +02:00
hodlbank 870d9a814a
[f] Fixes #965 - "Console doesnt have contract objects for contracts with pre-defined addresses configured".
[f] Fix for sometimes incorrect empty code detection in contract_deployer.js ("0x" vs "0x0").
2018-10-22 19:54:48 +02:00
Subramanian Venkatesan f686fec74a
ens resolve 2018-10-22 19:53:50 +02:00
Cryptomental bcc1711061
contract_deployer: Redeploy if track field is set to false.
Always deploy the contract regardless if already deployed
when 'track' field in the contract configuration is specified
and set to false.

In line with #938 requirements:

* If a contract has the track field set to false, that contract
  will always deploy.
* If the track field is set to true, then the existing deployment
  tracking mechanism will be active for that contract.
* If the field is not set, it should be assumed to true by default

Refs: https://github.com/embark-framework/embark/issues/938
2018-10-22 19:35:57 +02:00
hodlbank e13c0b3724
[a] Added applyArgumentPlugins before _determineArguments in ContractDeployer for plugins that calculate arguments dynamically.
[m] Made possible for deploy:contract:beforeDeploy plugin to modify arguments list.
2018-10-22 19:25:18 +02:00
Cryptomental 78c5055902
contracts_manager, deployment: Emit outputError whenever build error or deployment error happens.
Emit outputError when:
 * contracts cannot be built
 * contracts cannot be deployed

Refs: https://github.com/embark-framework/embark/issues/946
2018-10-22 19:25:17 +02:00
Iuri Matias 05962a288d lint is mother; lint is father 2018-09-26 18:57:55 -04:00
Iuri Matias 44dad44ef4 increase estimated gas slightly & randomly 2018-09-26 18:45:06 -04:00
Iuri Matias 2374cb1641 limit deployment to 1 for now 2018-09-26 18:44:36 -04:00
Anthony Laibe b8d3f3cd11 Fix warning 2018-09-25 14:59:08 +01:00
Anthony Laibe 1dfd2e980f Reduce coupling by using action for event 2018-09-22 15:08:50 +01:00
Anthony Laibe e20d7bfc6a Fix race condition on deploy tracker 2018-09-22 14:43:10 +01:00
Iuri Matias c569dc9d21 add missing semi-colon 2018-09-22 09:21:30 -04:00
Iuri Matias 3b6251eeb1 improve some deployment error messages 2018-09-21 17:52:32 -04:00
Andre Medeiros 9151466a75 Simplify code 2018-09-18 16:36:21 -04:00
Andre Medeiros f54d572b3d Handle cases where deploy address isn't set 2018-09-18 16:30:32 -04:00
Iuri Matias 32a1ba0f32 fix dashboard state so it doesn't show pending for contracts that were not deployed due to deployIf directive 2018-09-15 12:20:20 -04:00
Jonathan Rainville 4c912b8ecf stop on error 2018-09-12 12:04:33 -04:00
Jonathan Rainville 9f7a932252 don't stop on contract fail 2018-09-12 11:55:29 -04:00
Andre Medeiros 4a947d4783 Show an error message on account parameters 2018-09-12 09:00:20 -04:00
Anthony Laibe 5ad17be140 Fix Gas Price 2018-09-04 08:21:31 +01:00
Anthony Laibe df651865c1 Enable no-else-return 2018-08-30 14:53:04 +01:00
Anthony Laibe c94b5574cf Silent already deployed 2018-08-29 11:23:24 +01:00
Iuri Matias 4305d63108 clarify param is not used 2018-08-24 10:31:40 -04:00
Iuri Matias c52142cb4c move always deploy on tests to deploy tracker 2018-08-24 08:59:56 -04:00
Iuri Matias 8f5b47adf4 add deployIf directive support 2018-08-23 18:00:52 -04:00
Iuri Matias a56431d19a refactor run actions for events to a reduce; add initial plug for shouldDeploy using deployIf 2018-08-23 16:25:28 -04:00
Anthony Laibe a7b0cea09b Console via IPC do not run on deploy 2018-08-21 16:10:22 -04:00
Jonathan Rainville 8f3a42b926 catch $accounts in contract config 2018-08-21 16:09:49 -04:00
Andre Medeiros 8e396a17d8 Progress 2018-08-21 16:09:13 -04:00
Jonathan Rainville 3a621f3efd use async auto to deploy parallely 2018-08-21 16:09:13 -04:00