Commit Graph

3331 Commits

Author SHA1 Message Date
Michael Bradley, Jr 6149921562 rev comments 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 65d2153638 prefer early return for config.stats tests 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 9e62d9c1a9 isDir test should support possible use of '\' by devs on Windows 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8bec33177e rm some else clauses 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f4b11ce29f explanatory comment 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 382122c6d9 mapCb -> eachCb 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 04a5e3335d self.logger -> self.logger.error 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 1e97a6478b prefer path.delimiter 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr d14ee86c32 if dapp has a webpack.config.js, make a backup copy and proceed 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f66552b044 errorMessage helper moved to utils 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr c8cd5f4229 consistent indentation 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 46c4aea520 rev comment re: NODE_PATH in webpack config 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr e0fda460ba --pipeline option for `embark console`, defaults to 'development' 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr cec7dc5750 DRY resolve 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 2c54349c33 rev comment re: NODE_PATH 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 792a8f57eb consistent handling of error messages, no double reporting 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr ba98f76a10 no separator if proces.env.NODE_PATH is falsy 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr d4f8dd6608 rev comment re: NODE_PATH 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 421927d815 paths more DRY 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f1edc28f6d anchoredPath helper (more DRY) 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 67147f2cad make the linter happy 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 7fb9c552dc assetFileWrite no longer processes files corresponding to .js keys 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 0161a9b402 "writing file" messages for files that will be written by webpack 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr e1fb746aa7 relocate webpack.config.js under lib/pipeline/ 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 2e96557875 rev comment 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 198f7c37ac source maps gen'd by development config 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr d994f7507a webpack writes to buildDir 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 48e67973cf rev entry 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr bfeee5eb4d load embark.json 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 285534abeb rev comment 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 53a4fd2089 rm redundant setup of env vars 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 76502fa693 rm utils.pwd() -- redundant now that fs.dappPath is anchored to env var 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f0f95554a5 prefer fs.dappPath 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8be1090a44 prefer joinPath to +'ing strings together 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 40c14a08de whitespace 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 019f0b68c8 anchor fs.dappPath, fs.embarkPath to env vars setup in cmd.js 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr b7fd109237 setup env vars w/in cmd.js 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 7123d2730a rev webpack cfg such that when embark is global the cfg works from w/in a dapp (ejected) or w/in embark (default) 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr d6aafa17be compression-webpack-plugin dep 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 4acf0ad58d webpack compression plugin (activated in production config) 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 16856eadf0 rev notes 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 46209bef65 rev comments 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr b3c8e5fa45 missing spaces 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 3ad834d93d rev comment to reflect code changes 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 2670476d5e `embark eject-webpack` command 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 35f92f2ae8 more DRY re: config 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 04fcb1510a rev comment 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 1f56f717b8 'running webpack' message should indicate config name 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr df84fce953 support .jsx 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 7291fd1187 can use `this`, don't need `self` 2018-08-24 15:04:15 -05:00