Pascal Precht
5fc9f076dd
fix(commands/graph): don't start blockchain node when generating graphs
2018-10-22 19:40:52 +02:00
Pascal Precht
80c80e9beb
fix(commands/build): don't start blockchain node when `--contracts` is used
...
Prior to this commit `$ embark build --contracts` spinned up a blockchain node
which is not necessary as `--contracts` can be seen as a "compile only" option.
This commit ensures we don't start any web3 services with `--contracts` is used.
2018-10-22 19:40:52 +02:00
Michael Bradley, Jr
965c22d108
bin/embark handles checkDeps
2018-10-22 19:39:27 +02:00
Michael Bradley, Jr
fd856f8163
PKG_PATH, pkgPath
2018-10-22 19:39:26 +02:00
hodlbank
f41bcd55d6
[f] Fix for #971 - "Fatal error when Ethereum node going offline".
...
[a] Added .once() into Events.
2018-10-22 19:39:26 +02:00
Subramanian Venkatesan
ee77ac7f7f
Adds solc option to tests. Runs smart contract tests using remix-tests
...
Ref: #817
2018-10-22 19:39:24 +02:00
Pascal Precht
a0ef234fea
feat(modules/pipeline): move pipeline into its own module plugin
...
This is the first step of refactoring Embark's pipeline abstraction into
dedicated plugin modules that take advantage of Embark's event system.
With this commit we're moving `Pipeline` into `lib/modules/pipeline` and
introduce a new command handler `pipeline:build`. Embark's engine now
requests builds via this command handler.
Notice that `Watch` still lives in `lib/pipeline` as this is a step-by-step
refactoring to reduce chances of introducing regressions.
2018-10-22 19:35:58 +02:00
Michael Bradley, Jr
882271dc60
rev file name to better reflect its purpose
2018-10-22 19:35:56 +02:00
Michael Bradley, Jr
ae878fd7c8
extract copy/preserve logic into a helper in lib/core/fs
...
preserved files should end with <number>.<ext> vs. <ext>.<number>
2018-10-22 19:35:55 +02:00
Michael Bradley, Jr
b2f56a9eb1
eject webpack overrides
2018-10-22 19:35:52 +02:00
Cryptomental
10bf3e4412
cmd, cmd_controller, graph: Add --output option to graph.
...
Add optional --output argument to graph generator. The argument allows
to specify a filepath for graph output. Default filepath is ./diagram.svg
if the argument is not specified.
Refs: https://github.com/embark-framework/embark/issues/944
2018-10-22 19:25:18 +02:00
Cryptomental
0483920421
cmd, run_tests: Add --nobrowser option for runCoverage.
...
Do not start browser during coverage run when --nobrowser option is passed.
Refs: https://github.com/embark-framework/embark/issues/941
2018-10-22 19:25:18 +02:00
Anthony Laibe
7e12f80eda
Address PR feedback
2018-10-22 19:25:16 +02:00
Anthony Laibe
850a80c90c
ENS config use the actual network ID
...
Instead of relying on the name of network.
Fetch the real network id and configure ENS
based on that value
2018-10-22 19:25:16 +02:00
Anthony Laibe
e593ba5e42
Remove unneeded logger.error
...
The pipeline and the deployer/compiler display
the error themselves
2018-10-22 19:25:15 +02:00
Iuri Matias
1fd3cd268f
Merge pull request #907 from embark-framework/bug_fix/upload-cmd-ens-setprovider-missing
...
upload command should unconditionally start the "namingSystem" service
2018-09-26 09:20:46 -04:00
Michael Bradley, Jr
79af0c0186
`embark upload` unconditionally starts the "namingSystem" service
2018-09-25 11:09:38 -05:00
Michael Bradley, Jr
0e5989bf40
rev --template
...
if option is used, param must be supplied
"GitHub repository" -> "git host" in help output
2018-09-24 17:46:29 -05:00
Iuri Matias
9ac3f56c98
update template option message
2018-09-21 18:18:21 -04:00
Iuri Matias
af823f98b6
clarify template option; hide ens option; update typo suggestion list
2018-09-21 17:51:33 -04:00
Anthony Laibe
09de3201a1
Set default account back
2018-09-20 11:49:05 +01:00
Iuri Matias
501ddd610e
Merge pull request #869 from embark-framework/cli/coverage-only-with-vm
...
--coverage requires --node be "vm"
2018-09-19 11:58:39 -04:00
Michael Bradley, Jr
a6231851b0
consistent quotes
2018-09-18 15:06:27 -05:00
Michael Bradley, Jr
fc68e9be3c
rev --gasDetails help output
2018-09-18 15:06:04 -05:00
Michael Bradley, Jr
b2c7ef37b7
rev --node help output
2018-09-18 15:06:04 -05:00
Michael Bradley, Jr
dbac72ea7d
--coverage option only support "vm" node
2018-09-18 15:05:52 -05:00
Michael Bradley, Jr
3806dd6cd1
`embark reset` should remove a dapp's coverage/ subdir
2018-09-18 14:22:47 -05:00
Michael Bradley, Jr
1f652a7672
deploy -> deployment
2018-09-18 12:55:37 -05:00
Iuri Matias
904c716d89
Merge pull request #856 from embark-framework/features/config-browser-open
...
cli and config options for browser auto-open
2018-09-18 13:11:55 -04:00
Michael Bradley, Jr
a49d8eafa1
clarify re: GitHub
2018-09-18 10:24:40 -05:00
Michael Bradley, Jr
19dc3a1d13
match wording on docs site
2018-09-17 18:50:47 -05:00
Michael Bradley, Jr
c360975e8f
webServer svc doesn't need to handle cli opts (handled in core/config)
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
2b5268dc84
test null when populating webserver config derived from cli
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
638fb4ee27
allow config to determine webserver enabled if no --noserver cli opt
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
a966ecb131
for --host,--port coerce falsy and bool to null
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
64027a5ee4
--nobrowser cli option
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
6e60566b27
add line break between error message and help output
2018-09-14 20:44:22 -05:00
emizzle
6e444aaf65
simplied the valid option check to pure regex
2018-09-15 11:38:48 +10:00
emizzle
269d544ab3
show option usage help with invalid `—node` option and simplied the valid option check to pure regex
2018-09-15 11:36:24 +10:00
Michael Bradley, Jr
203039763d
`node` won't ever be falsy owing to `|| 'vm'`
2018-09-14 20:25:22 -05:00
Michael Bradley, Jr
f790ecdcbb
be more explicit about setting the default option value to 'vm'
2018-09-14 20:15:48 -05:00
Michael Bradley, Jr
ac930d0be0
report error and exit if --node option value is not valid
2018-09-14 19:58:23 -05:00
Iuri Matias
9f1cb71117
Merge pull request #837 from embark-framework/eject_msg
...
modify eject msg
2018-09-14 18:20:42 -04:00
Iuri Matias
3c167b197c
Merge pull request #823 from embark-framework/features/embark-help-addition
...
`embark test —node` help, plus fix for vm option
2018-09-14 18:13:07 -04:00
Iuri Matias
9b2fa9402b
Merge pull request #822 from embark-framework/bugfix/circular-json
...
Fix circular JSON and swarm api require
2018-09-14 18:11:34 -04:00
emizzle
7658818571
remove custom option validation
...
Was trying to get a bit too fancy and show an error message if the user didn’t provide a valid value. Instead, if they use `—node` and the value is not a valid option, `vm` will be the default.
2018-09-14 15:23:38 +10:00
Iuri Matias
6d54a40bb2
Merge pull request #827 from embark-framework/bug_fix/prepend-embark-plugin-install
...
Prepend "embark-" to plugin names and little fixes
2018-09-13 19:46:49 -04:00
Iuri Matias
98b999618b
modify eject msg
2018-09-13 16:43:43 -04:00
Jonathan Rainville
43a9640297
add option to generate the coverage
2018-09-13 14:30:15 -04:00
Jonathan Rainville
ddb1872db5
fix undefined message in console
2018-09-13 10:28:03 -04:00