Commit Graph

196 Commits

Author SHA1 Message Date
Michael Bradley, Jr 8fa5bddde5 rev comment re: webpack-bundle-analyzer 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 6149921562 rev comments 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 65d2153638 prefer early return for config.stats tests 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 9e62d9c1a9 isDir test should support possible use of '\' by devs on Windows 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8bec33177e rm some else clauses 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f4b11ce29f explanatory comment 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 382122c6d9 mapCb -> eachCb 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 04a5e3335d self.logger -> self.logger.error 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f66552b044 errorMessage helper moved to utils 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr c8cd5f4229 consistent indentation 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 46c4aea520 rev comment re: NODE_PATH in webpack config 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr cec7dc5750 DRY resolve 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 792a8f57eb consistent handling of error messages, no double reporting 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 421927d815 paths more DRY 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 67147f2cad make the linter happy 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 7fb9c552dc assetFileWrite no longer processes files corresponding to .js keys 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 0161a9b402 "writing file" messages for files that will be written by webpack 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr e1fb746aa7 relocate webpack.config.js under lib/pipeline/ 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 53a4fd2089 rm redundant setup of env vars 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8be1090a44 prefer joinPath to +'ing strings together 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr b3c8e5fa45 missing spaces 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 3ad834d93d rev comment to reflect code changes 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 35f92f2ae8 more DRY re: config 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 04fcb1510a rev comment 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 1f56f717b8 'running webpack' message should indicate config name 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 7291fd1187 can use `this`, don't need `self` 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 963ecc0d92 formatting 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 878186660b change timing of "writing file" messages 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr f654c0a013 single webpack run 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr e9ec968598 whitespace 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 6282e092f1 note/question 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 2f2f007d5c use embark's webpack config, or a dapp's webpack config if it exists 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr b41f5a397d --pipeline option for `ebmark build|run` to spec webpack config name 2018-08-24 15:04:15 -05:00
Jonathan Rainville 86f1cf51d2 enable node=embark 2018-08-23 12:54:43 -04:00
Michael Bradley, Jr eb874f32ac corejs2 per @babel/plugin-transform-runtime@7.0.0-rc.1 2018-08-21 16:09:49 -04:00
Michael Bradley, Jr d0555fe23c win compat 2018-08-21 16:05:58 -04:00
Michael Bradley, Jr 314edadb57 Revert "Merge pull request #663 from embark-framework/revert-656-bug_fix/dot.embark_versions_modules"
This reverts commit 7859c384ca, reversing
changes made to a58f21c303.
2018-08-21 16:05:58 -04:00
Iuri Matias 63b01a32d4 Revert ".embark/versions modules" 2018-08-21 16:05:58 -04:00
Michael Bradley, Jr 7cffe94059 revs re: .embark/versions 2018-08-21 16:04:22 -04:00
Iuri Matias 29b0d01f22 move processes into core 2018-08-21 16:04:22 -04:00
Iuri Matias 3e6210c6d1 add missing import 2018-08-21 16:03:35 -04:00
Iuri Matias 2ed7238190 move process files into processes folder 2018-08-21 16:02:18 -04:00
Michael Bradley, Jr b0638d6585 more conservative: only modify webpack's subclass of ProcessWrapper 2018-08-21 15:47:05 -04:00
Michael Bradley, Jr 250d80e0ff env options property doesn't need to be passed to ProcessLauncher 2018-08-21 15:47:05 -04:00
Michael Bradley, Jr d3ffa90cb5 rm disabled lines 2018-08-21 15:47:05 -04:00
Michael Bradley, Jr 971ca8d3ae webpack mode should be 'none' unless embark's mode is 'production' 2018-08-21 15:47:05 -04:00
Michael Bradley, Jr 52ef230d47 comment re: use of webpack-bundle-analyzer to visualize stats.json 2018-08-21 15:47:05 -04:00
Michael Bradley, Jr a7205e47e6 disable stats gen (should be activated via cfg file and/or cli opts) 2018-08-21 15:47:05 -04:00
Michael Bradley, Jr ece251a5bf rev wp config comments 2018-08-21 15:47:05 -04:00
Michael Bradley, Jr e05918d84f stats.report/json is being written to .embark/ not dist/ 2018-08-21 15:47:05 -04:00