Commit Graph

2021 Commits

Author SHA1 Message Date
Andre Medeiros 05dea5844a Fix the way we pass compiler options instead of assuming via the environment 2018-08-30 13:27:18 -04:00
Andre Medeiros 2c2e54b613 Fix feedback 2018-08-30 13:01:13 -04:00
Andre Medeiros bc5de4ef90 Support modifiers 2018-08-30 12:49:41 -04:00
Andre Medeiros 824353fb32 Lint 2018-08-28 13:51:55 -04:00
Andre Medeiros 543f883b7d Fix consolidation of coverage and compiler events; Cleanup 2018-08-28 13:39:18 -04:00
Andre Medeiros 4c127d1192 Events 2018-08-28 11:27:37 -04:00
Andre Medeiros 4e9d2823e5 Improvements 2018-08-28 11:27:37 -04:00
Andre Medeiros 5dcd679e12 Add for loops and variable declarations; Coverage improvements 2018-08-28 11:27:37 -04:00
Michael Bradley, Jr 8fa5bddde5 rev comment re: webpack-bundle-analyzer 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 6149921562 rev comments 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 65d2153638 prefer early return for config.stats tests 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 9e62d9c1a9 isDir test should support possible use of '\' by devs on Windows 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8bec33177e rm some else clauses 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f4b11ce29f explanatory comment 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 382122c6d9 mapCb -> eachCb 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 04a5e3335d self.logger -> self.logger.error 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f66552b044 errorMessage helper moved to utils 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr c8cd5f4229 consistent indentation 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 46c4aea520 rev comment re: NODE_PATH in webpack config 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr cec7dc5750 DRY resolve 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 792a8f57eb consistent handling of error messages, no double reporting 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 421927d815 paths more DRY 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f1edc28f6d anchoredPath helper (more DRY) 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 67147f2cad make the linter happy 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 7fb9c552dc assetFileWrite no longer processes files corresponding to .js keys 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 0161a9b402 "writing file" messages for files that will be written by webpack 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr e1fb746aa7 relocate webpack.config.js under lib/pipeline/ 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 53a4fd2089 rm redundant setup of env vars 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 76502fa693 rm utils.pwd() -- redundant now that fs.dappPath is anchored to env var 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f0f95554a5 prefer fs.dappPath 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8be1090a44 prefer joinPath to +'ing strings together 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 40c14a08de whitespace 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 019f0b68c8 anchor fs.dappPath, fs.embarkPath to env vars setup in cmd.js 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr b3c8e5fa45 missing spaces 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 3ad834d93d rev comment to reflect code changes 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 35f92f2ae8 more DRY re: config 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 04fcb1510a rev comment 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 1f56f717b8 'running webpack' message should indicate config name 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 7291fd1187 can use `this`, don't need `self` 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 963ecc0d92 formatting 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 878186660b change timing of "writing file" messages 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr f654c0a013 single webpack run 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr e9ec968598 whitespace 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 6282e092f1 note/question 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 2f2f007d5c use embark's webpack config, or a dapp's webpack config if it exists 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr c60d26e258 make fs.embarkPath more flexible 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr b41f5a397d --pipeline option for `ebmark build|run` to spec webpack config name 2018-08-24 15:04:15 -05:00
Iuri Matias f0a6b913c4
Merge pull request #747 from embark-framework/features/password-protected-keyfiles
Unlock account using keystore file with password
2018-08-24 16:01:55 -04:00
Iuri Matias a0d864b8ae
Merge pull request #746 from embark-framework/bug_fix/tests-ws-bug
Fix test_app with a WS node
2018-08-24 15:53:54 -04:00
Jonathan Rainville 9d4a3fd228 if there is a password field in privateKeyFile object, decode keystore 2018-08-24 15:30:44 -04:00