fix lookup and also enable lookup for new subdomains

This commit is contained in:
Jonathan Rainville 2018-07-23 17:11:21 -04:00 committed by Pascal Precht
parent 9125fe82d9
commit ead79cd77f
No known key found for this signature in database
GPG Key ID: 0EE28D8D6FD85D7D
2 changed files with 3 additions and 29 deletions

View File

@ -243,6 +243,7 @@ __embarkENS.lookup = function (address, callback) {
};
__embarkENS.registerSubDomain = function (name, address, callback) {
const self = this;
callback = callback || function () {};
if (!web3.eth.defaultAccount) {

View File

@ -225,41 +225,14 @@ class ENS {
});
}
registerConfigDomains(config, cb) {
const self = this;
self.events.request("blockchain:defaultAccount:get", (defaultAccount) => {
self.events.request("blockchain:contract:create",
{abi: config.registrarAbi, address: config.registrarAddress},
(registrar) => {
async.each(Object.keys(self.registration.domains), (subDomainName, eachCb) => {
const toSend = registrar.methods.register(utils.sha3(subDomainName),
defaultAccount, self.registration.domains[subDomainName]);
toSend.estimateGas().then(gasEstimated => {
return toSend.send({gas: gasEstimated + 1000, from: defaultAccount}).then(transaction => {
if (transaction.status !== "0x1" && transaction.status !== "0x01" && transaction.status !== true) {
return eachCb('Failed to register. Check gas cost.');
}
eachCb(null, transaction);
}).catch(err => {
eachCb('Failed to register with error: ' + (err.message || err));
});
}).catch(err => {
eachCb("Register would error. Is it already registered? Do you have token balance? Is Allowance set? " + (err.message || err));
});
}, cb);
});
});
}
addENSToEmbarkJS() {
const self = this;
// get namehash, import it into file
self.events.request("version:get:eth-ens-namehash", function (EnsNamehashVersion) {
self.events.request("version:get:eth-ens-namehash", function(EnsNamehashVersion) {
let currentEnsNamehashVersion = require('../../../package.json').dependencies["eth-ens-namehash"];
if (EnsNamehashVersion !== currentEnsNamehashVersion) {
self.events.request("version:getPackageLocation", "eth-ens-namehash", EnsNamehashVersion, function (err, location) {
self.events.request("version:getPackageLocation", "eth-ens-namehash", EnsNamehashVersion, function(err, location) {
self.embark.registerImportFile("eth-ens-namehash", fs.dappPath(location));
});
}