status-im
/
embark-area-51
mirror of https://github.com/status-im/embark-area-51.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix possible double callback

This commit is contained in:
Jonathan Rainville 2018-06-14 10:30:47 -04:00
parent faaefd349c
commit cb8fd1cf31
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/contracts/deploy_manager.js
View File

@ -133,8 +133,7 @@ class DeployManager {
return callback(new Error("error running afterDeploy"));
}
// TODO: convert to for to avoid repeated callback
for(let cmd of onDeployCode) {
async.each(onDeployCode, (cmd, eachCb) => {
self.logger.info("executing: " + cmd);
try {
RunCode.doEval(cmd, web3);
@ -142,11 +141,14 @@ class DeployManager {
if (e.message.indexOf("invalid opcode") >= 0) {
self.logger.error('the transaction was rejected; this usually happens due to a throw or a require, it can also happen due to an invalid operation');
}
return callback(new Error(e));
return eachCb(new Error(e));
}
}
eachCb();
}, (err) => {
callback(err, contractsManager);
});
callback(null, contractsManager);
}
], function (err, result) {
if (err) {