From ac45b7a19bd172a99bce1cad3dc976f98055cf47 Mon Sep 17 00:00:00 2001 From: Iuri Matias Date: Fri, 18 May 2018 20:32:40 -0400 Subject: [PATCH] remove unneded assigment; add clarification/TODO --- lib/core/engine.js | 4 ++-- lib/modules/whisper/index.js | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/core/engine.js b/lib/core/engine.js index 5d133601..9b16e829 100644 --- a/lib/core/engine.js +++ b/lib/core/engine.js @@ -281,11 +281,11 @@ class Engine { web3: options.web3 }); - this.web3 = this.blockchain.web3; - this.registerModule('whisper', { addCheck: this.servicesMonitor.addCheck.bind(this.servicesMonitor), communicationConfig: this.config.communicationConfig, + // TODO: this should not be needed and should be deducted from the config instead + // the eth provider is not necessary the same as the whisper one web3: this.web3 }); } diff --git a/lib/modules/whisper/index.js b/lib/modules/whisper/index.js index 4546dd24..624fb63e 100644 --- a/lib/modules/whisper/index.js +++ b/lib/modules/whisper/index.js @@ -8,6 +8,7 @@ class Whisper { this.events = embark.events; this.communicationConfig = options.communicationConfig; this.addCheck = options.addCheck; + // TODO: this should not be needed and should be deducted from the config instead this.web3 = options.web3; this.embark = embark;