status-im
/
embark-area-51
mirror of https://github.com/status-im/embark-area-51.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

can use `this`, don't need `self`

This commit is contained in:
Michael Bradley, Jr 2018-08-16 16:38:50 -05:00
parent 963ecc0d92
commit 7291fd1187
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/pipeline/webpackProcess.js
View File

@ -29,7 +29,6 @@ class WebpackProcess extends ProcessWrapper {
} }
async webpackRun(assets, importsList, callback) { async webpackRun(assets, importsList, callback) {
const self = this;
try { try {
await writeFile( await writeFile(
fs.dappPath('.embark/embark-aliases.json'), fs.dappPath('.embark/embark-aliases.json'),
@ -64,18 +63,18 @@ class WebpackProcess extends ProcessWrapper {
// + array of named config objects // + array of named config objects
// + config object // + config object
if (typeof config === 'function') { if (typeof config === 'function') {
config = await config(self.webpackConfigName); config = await config(this.webpackConfigName);
} else if (Array.isArray(config)) { } else if (Array.isArray(config)) {
config = config.filter(cfg => cfg.name === self.webpackConfigName); config = config.filter(cfg => cfg.name === this.webpackConfigName);
if (!config.length) { if (!config.length) {
const errMsg = `no webpack config has the name '${self.webpackConfigName}'`; const errMsg = `no webpack config has the name '${this.webpackConfigName}'`;
console.error(errMsg); console.error(errMsg);
return callback(errMsg); return callback(errMsg);
// ?? should the message be wrapped in new Error() // ?? should the message be wrapped in new Error()
} }
if (config.length > 1) { if (config.length > 1) {
console.warn( console.warn(
`detected ${config.length} webpack configs having the name '${self.webpackConfigName}', using the first one` `detected ${config.length} webpack configs having the name '${this.webpackConfigName}', using the first one`
); );
} }
config = config[0]; config = config[0];
@ -103,12 +102,12 @@ class WebpackProcess extends ProcessWrapper {
} }
try { try {
if (config.stats && config.stats !== 'none') { if (config.stats && config.stats !== 'none') {
self._log('info', 'writing file '+ ('.embark/stats.report').bold.dim); this._log('info', 'writing file '+ ('.embark/stats.report').bold.dim);
await writeFile( await writeFile(
fs.dappPath('.embark/stats.report'), fs.dappPath('.embark/stats.report'),
stats.toString(config.stats) stats.toString(config.stats)
); );
self._log('info','writing file '+ ('.embark/stats.json').bold.dim); this._log('info','writing file '+ ('.embark/stats.json').bold.dim);
await writeFile( await writeFile(
fs.dappPath('.embark/stats.json'), fs.dappPath('.embark/stats.json'),
JSON.stringify(stats.toJson(config.stats)) JSON.stringify(stats.toJson(config.stats))