add jshint exceptions and TODO
This commit is contained in:
parent
fff31d6995
commit
4b1a16b100
|
@ -83,17 +83,17 @@ Deploy.prototype.checkAndDeployContract = function(contract, params, callback) {
|
|||
self.deployTracker.save();
|
||||
self.logger.contractsState(self.contractsManager.contractsState());
|
||||
|
||||
// TODO: replace with separate process so it's isolated and with
|
||||
// TODO: replace evals with separate process so it's isolated and with
|
||||
// a callback
|
||||
if (contract.onDeploy !== undefined) {
|
||||
self.logger.info('executing onDeploy commands');
|
||||
var abiGenerator = new ABIGenerator({}, self.contractsManager);
|
||||
web3 = self.web3;
|
||||
var abi = abiGenerator.generateContracts(false);
|
||||
eval(abi);
|
||||
eval(abi); // jshint ignore:line
|
||||
|
||||
var cmds = contract.onDeploy.join(';\n');
|
||||
eval(cmds);
|
||||
eval(cmds); // jshint ignore:line
|
||||
}
|
||||
|
||||
callback();
|
||||
|
|
|
@ -62,7 +62,9 @@ Test.prototype.deployAll = function(contractsConfig, cb) {
|
|||
self.web3.eth.getAccounts(function(err, accounts) {
|
||||
var web3 = self.web3;
|
||||
web3.eth.defaultAccount = accounts[0];
|
||||
eval(result);
|
||||
// TODO: replace evals with separate process so it's isolated and with
|
||||
// a callback
|
||||
eval(result); // jshint ignore:line
|
||||
cb();
|
||||
});
|
||||
});
|
||||
|
|
Loading…
Reference in New Issue